From: Jessica Yu <jeyu@kernel.org>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Cheng Jian <cj.chengjian@huawei.com>,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
chenwandun@huawei.com, xiexiuqi@huawei.com,
bobo.shaobowang@huawei.com, huawei.libin@huawei.com,
jikos@kernel.org
Subject: Re: [PATCH] module: make module symbols visible after init
Date: Thu, 4 Jun 2020 11:49:42 +0200 [thread overview]
Message-ID: <20200604094942.GA14963@linux-8ccs.fritz.box> (raw)
In-Reply-To: <alpine.LSU.2.21.2006031848020.26737@pobox.suse.cz>
+++ Miroslav Benes [03/06/20 19:00 +0200]:
>> In commit 0bd476e6c671 ("kallsyms: unexport kallsyms_lookup_name() and
>> kallsyms_on_each_symbol()") restricts the invocation for kernel unexported
>> symbols, but it is still incorrect to make the symbols of non-LIVE modules
>> visible to the outside.
>
>Why? It could easily break something somewhere. I didn't check properly,
>but module states are not safe to play with, so I'd be conservative here.
Fully agree here. And it is not incorrect to make the symbols of
non-live modules visible via kallsyms. For one, kallsyms needs to
be able to see a module's symbols already even while in the COMING
state, because we can already oops/panic inside the module during
parse_args(), and symbol resolution via kallsyms is needed here even
though the module is not live. I have not checked carefully yet if
there are other users of kallsyms out there that might need to see
module symbols even when it is still coming, but for the first reason
alone I would not make this change.
Jessica
next prev parent reply other threads:[~2020-06-04 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 14:12 [PATCH] module: make module symbols visible after init Cheng Jian
2020-06-03 17:00 ` Miroslav Benes
2020-06-04 9:49 ` Jessica Yu [this message]
2020-06-04 8:57 ` Petr Mladek
2020-06-04 12:55 ` chengjian (D)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604094942.GA14963@linux-8ccs.fritz.box \
--to=jeyu@kernel.org \
--cc=bobo.shaobowang@huawei.com \
--cc=chenwandun@huawei.com \
--cc=cj.chengjian@huawei.com \
--cc=huawei.libin@huawei.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).