Live-Patching Archive on lore.kernel.org
 help / color / Atom feed
From: Joe Lawrence <joe.lawrence@redhat.com>
To: live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>,
	Yannick Cote <ycote@redhat.com>
Subject: [PATCH v3 0/3] selftests/livepatch: small script cleanups
Date: Thu, 18 Jun 2020 14:10:37 -0400
Message-ID: <20200618181040.21132-1-joe.lawrence@redhat.com> (raw)

Hi Petr,

Given the realization about kernel log timestamps and partial log
comparison with v2, I respun a final version dropping the dmesg --notime
patch, fixed any rebase conflicts, and added a comment per your
suggestion.

I copied all the ack and review tags from v2 since the patchset is
unchanged otherwise.  Hopefully this v3 minimizes any maintainer
fiddling on your end.

I did iterate through the patches and verified that I could run each
multiple times without the dmesg comparison getting confused.

Thanks,

-- Joe


v3:

- when modifying the dmesg comparision to select only new messages in
  patch 1, add a comment explaining the importance of timestamps to
  accurately pick from where the log left off at start_test [pmladek]

- since Petr determined that the timestamps were in fact very important
  to maintain for the dmesg / diff comparision, drop the patch which
  added --notime to dmesg invocations [pmladek]

- update the comparision regex filter for 'livepatch:' now that it's
  going to be prefixed by '[timestamp] ' and no longer at the start of
  the buffer line.  This part of the log comparison should now be
  unmodified by the patchset.

Joe Lawrence (3):
  selftests/livepatch: Don't clear dmesg when running tests
  selftests/livepatch: refine dmesg 'taints' in dmesg comparison
  selftests/livepatch: add test delimiter to dmesg

 tools/testing/selftests/livepatch/README      | 16 +++---
 .../testing/selftests/livepatch/functions.sh  | 37 ++++++++++++-
 .../selftests/livepatch/test-callbacks.sh     | 55 ++++---------------
 .../selftests/livepatch/test-ftrace.sh        |  4 +-
 .../selftests/livepatch/test-livepatch.sh     | 12 +---
 .../selftests/livepatch/test-shadow-vars.sh   |  4 +-
 .../testing/selftests/livepatch/test-state.sh | 21 +++----
 7 files changed, 68 insertions(+), 81 deletions(-)

-- 
2.21.3


             reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 18:10 Joe Lawrence [this message]
2020-06-18 18:10 ` [PATCH v3 1/3] selftests/livepatch: Don't clear dmesg when running tests Joe Lawrence
2020-06-18 18:10 ` [PATCH v3 2/3] selftests/livepatch: refine dmesg 'taints' in dmesg comparison Joe Lawrence
2020-06-18 18:10 ` [PATCH v3 3/3] selftests/livepatch: add test delimiter to dmesg Joe Lawrence
2020-06-19  9:06 ` [PATCH v3 0/3] selftests/livepatch: small script cleanups Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200618181040.21132-1-joe.lawrence@redhat.com \
    --to=joe.lawrence@redhat.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    --cc=ycote@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Live-Patching Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/live-patching/0 live-patching/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 live-patching live-patching/ https://lore.kernel.org/live-patching \
		live-patching@vger.kernel.org
	public-inbox-index live-patching

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.live-patching


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git