From: Petr Mladek <pmladek@suse.com> To: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Joe Lawrence <joe.lawrence@redhat.com>, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] docs/livepatch: Add new compiler considerations doc Date: Thu, 6 Aug 2020 14:03:36 +0200 Message-ID: <20200806120336.GP24529@alley> (raw) In-Reply-To: <20200722205139.hwbej2atk2ejq27n@treble> On Wed 2020-07-22 15:51:39, Josh Poimboeuf wrote: > On Wed, Jul 22, 2020 at 01:03:03PM -0400, Joe Lawrence wrote: > > On 7/21/20 7:04 PM, Josh Poimboeuf wrote: > > > On Tue, Jul 21, 2020 at 12:14:06PM -0400, Joe Lawrence wrote: > > > > Compiler optimizations can have serious implications on livepatching. > > > > Create a document that outlines common optimization patterns and safe > > > > ways to livepatch them. > > > > > > > > Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com> > > > > > > There's a lot of good info here, but I wonder if it should be > > > reorganized a bit and instead called "how to create a livepatch module", > > > because that's really the point of it all. > > > > > > > That would be nice. Would you consider a stand-alone compiler-optimizations > > doc an incremental step towards that end? Note that the other files > > (callbacks, shadow-vars, system-state) in their current form might be as > > confusing to the newbie. > > It's an incremental step towards _something_. Whether that's a cohesive > patch creation guide, or just a growing hodgepodge of random documents, > it may be too early to say :-) Yes, it would be nice to have a cohesive documentation. But scattered pieces are better than nothing. > > > I'm thinking a newcomer reading this might be lost. It's not > > > necessarily clear that there are currently two completely different > > > approaches to creating a livepatch module, each with their own quirks > > > and benefits/drawbacks. There is one mention of a "source-based > > > livepatch author" but no explanation of what that means. > > > > > > > Yes, the initial draft was light on source-based patching since I only > > really tinker with it for samples/kselftests. The doc was the result of an > > experienced livepatch developer and Sunday afternoon w/the compiler. I'm > > sure it reads as such. :) > > Are experienced livepatch developers the intended audience? If so I > question what value this document has in its current form. Presumably > experienced livepatch developers would already know this stuff. IMHO, this document is useful even for newbies. They might at least get a clue about these catches. It is better than nothing. I do not want to discourage Joe from creating even better documentation. But if he does not have interest or time to work on it, I am happy even for this piece. Acked-by: Petr Mladek <pmladek@suse.com> Best Regards, Petr
next prev parent reply index Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-21 16:14 [PATCH 0/2] livepatch: Add compiler optimization disclaimer/docs Joe Lawrence 2020-07-21 16:14 ` [PATCH 1/2] docs/livepatch: Add new compiler considerations doc Joe Lawrence 2020-07-21 23:04 ` Josh Poimboeuf 2020-07-22 17:03 ` Joe Lawrence 2020-07-22 20:51 ` Josh Poimboeuf 2020-08-06 12:03 ` Petr Mladek [this message] 2020-08-10 19:46 ` refactoring livepatch documentation was " Joe Lawrence 2020-09-01 17:12 ` Josh Poimboeuf 2020-09-02 14:00 ` Miroslav Benes 2020-09-02 13:45 ` Miroslav Benes 2020-07-21 16:14 ` [PATCH 2/2] samples/livepatch: Add README.rst disclaimer Joe Lawrence 2020-08-06 12:07 ` Petr Mladek 2020-09-02 13:46 ` Miroslav Benes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200806120336.GP24529@alley \ --to=pmladek@suse.com \ --cc=joe.lawrence@redhat.com \ --cc=jpoimboe@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=live-patching@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Live-Patching Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/live-patching/0 live-patching/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 live-patching live-patching/ https://lore.kernel.org/live-patching \ live-patching@vger.kernel.org public-inbox-index live-patching Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.live-patching AGPL code for this site: git clone https://public-inbox.org/public-inbox.git