From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BABFC4741F for ; Fri, 6 Nov 2020 14:27:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08693208C7 for ; Fri, 6 Nov 2020 14:27:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="hOSy8tf6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727055AbgKFO1n (ORCPT ); Fri, 6 Nov 2020 09:27:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:46544 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbgKFO1m (ORCPT ); Fri, 6 Nov 2020 09:27:42 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1604672860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fneYivF7KPk5Vezwqp16bHvlG7pQia60PP+ozhIKNOI=; b=hOSy8tf6Xv9bxsLj3BRpsgcu/m8tXPh77G9b08Scucev/08pfZ/oZN7WOboqt1Phltz0oY EY+Z7IhgTgZK8/cheL0CPQ+pGMcTvUW7Ysp6ShK8LBZpwqpEn7fzXD6giDnRBpzEP5qAeT BwsA/u4RxQJT0sh1JOGSdIWHppyWK2U= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CBFB7ABCC; Fri, 6 Nov 2020 14:27:39 +0000 (UTC) Date: Fri, 6 Nov 2020 15:27:38 +0100 From: Petr Mladek To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Masami Hiramatsu , Andrew Morton , Peter Zijlstra , Ingo Molnar , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Jonathan Corbet , Guo Ren , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Joe Lawrence , Kamalesh Babulal , Mauro Carvalho Chehab , Sebastian Andrzej Siewior , linux-doc@vger.kernel.org, linux-csky@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH 11/11 v3] ftrace: Add recording of functions that caused recursion Message-ID: <20201106142738.GX20201@alley> References: <20201106023235.367190737@goodmis.org> <20201106023548.102375687@goodmis.org> <20201106131317.GW20201@alley> <20201106084131.7dfc3a30@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201106084131.7dfc3a30@gandalf.local.home> Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On Fri 2020-11-06 08:41:31, Steven Rostedt wrote: > On Fri, 6 Nov 2020 14:13:17 +0100 > Petr Mladek wrote: > > > JFYI, the code reading and writing the cache looks good to me. > > > > It is still possible that some entries might stay unused (filled > > with zeroes) but it should be hard to hit in practice. It > > is good enough from my POV. > > You mean the part that was commented? Yeah, it is the comment problem when nr_records is pushed forward. > > > > I do not give Reviewed-by tag just because I somehow do not have power > > to review the entire patch carefully enough at the moment. > > No problem. Thanks for looking at it. > > I'm adding a link to this thread, so if someone wants proof you helped out > on this code, you can have them follow the links ;-) > > Anyway, even if I push this to linux-next where I stop rebasing code > (because of test coverage), I do rebase for adding tags. So if you ever get > around at looking at this code, I can add that tag later (before the next > merge window), or if you find something, I could fix it with a new patch and > give you a Reported-by. Good to know. Best Regards, Petr