From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C10CDC433FE for ; Tue, 7 Dec 2021 05:31:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234683AbhLGFfV (ORCPT ); Tue, 7 Dec 2021 00:35:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:26790 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234508AbhLGFfU (ORCPT ); Tue, 7 Dec 2021 00:35:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638855110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e4ghYP9B13gGvmZuLKDuOchy2naysfKvbuf3lUvYkHc=; b=ILiCplrXUFLPc9DWwvemnd0a7H8UajIsai+WDTBPSFqVOugb7C9EGBpKD6/g293lrKu3db 0+AS4lCMlDed30cFg8udqjK6CY2qt7tOggyaYKTypCVVaMHk3kWEdgS06mbFkVF2vegMZI RNXhAIDla1xuLJWGGXx04X13+BUA4hM= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-359-tc3IPrtmMqC_SUWG1iiEDQ-1; Tue, 07 Dec 2021 00:31:49 -0500 X-MC-Unique: tc3IPrtmMqC_SUWG1iiEDQ-1 Received: by mail-qt1-f197.google.com with SMTP id u14-20020a05622a198e00b002b2f35a6dcfso15387843qtc.21 for ; Mon, 06 Dec 2021 21:31:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e4ghYP9B13gGvmZuLKDuOchy2naysfKvbuf3lUvYkHc=; b=UJkcVBYlo+uWgziRvxGMMOvSOqbOyUbZJDmbcgaQdcjv12t9FsNeyPKuRK0PdONRk6 bPFZg+QFCMzvfjDWM7NGyTwnLc/19GKBprWMM+1LaBAqJoeQ76rp/Th1KIZCjnMNpPD0 IGfcGUtq2PrJtLbmqxVzgXrn1LeBSysObFJApZjl4GsZRM0eC9YPRMyMZObKnKl3b48m 44B4L7mIYYypGShPYBSntQhpwPQAbpDcM42Owz0Y5dIyedbm8DmKSoUtfJnY+UQJ5ct+ JMqVA5Em+yJzyworeNVz9sTn3/qYxOVmygD82P4NFnkk39ZP03HYsF+jWDg0Lfl3QWFY 08Ug== X-Gm-Message-State: AOAM533x9kwgt+nJBY2OyBuxHlLe1icN+QRgySkCcfwR6ow2df3uOOzi DeR2eYXhFAxlI6OOqwA0Oo/XcR+VY96dF7YMTbca3tzUa6R2LJVqSYaO9mpiJJnOD7fDOPLht7F HT8IqgjJB9MiIw1E9fiDZNKTW1Q== X-Received: by 2002:ac8:5b51:: with SMTP id n17mr19545774qtw.182.1638855108529; Mon, 06 Dec 2021 21:31:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJz454uO8EitNs/c6PtV9eniUKNKiTCgR5+N8W4WMPq1f0ryP+2pFiwPH4C3lFPQ4hkn9zJMiQ== X-Received: by 2002:ac8:5b51:: with SMTP id n17mr19545750qtw.182.1638855108304; Mon, 06 Dec 2021 21:31:48 -0800 (PST) Received: from treble ([2600:1700:6e32:6c00::45]) by smtp.gmail.com with ESMTPSA id s12sm8814877qtk.61.2021.12.06.21.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 21:31:47 -0800 (PST) Date: Mon, 6 Dec 2021 21:31:42 -0800 From: Josh Poimboeuf To: Ard Biesheuvel Cc: Peter Zijlstra , Alexander Lobakin , linux-hardening@vger.kernel.org, X86 ML , Jesse Brandeburg , Kristen Carlson Accardi , Kees Cook , Miklos Szeredi , Tony Luck , Bruce Schlobohm , Jessica Yu , kernel test robot , Miroslav Benes , Evgenii Shatokhin , Jonathan Corbet , Masahiro Yamada , Michal Marek , Nick Desaulniers , Herbert Xu , "David S. Miller" , Thomas Gleixner , Will Deacon , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Arnd Bergmann , Nathan Chancellor , Masami Hiramatsu , Marios Pomonis , Sami Tolvanen , Linux Kernel Mailing List , Linux Kbuild mailing list , linux-arch , live-patching@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v8 07/14] kallsyms: Hide layout Message-ID: <20211207053142.d4xvkqs57zob2v2i@treble> References: <20211202223214.72888-1-alexandr.lobakin@intel.com> <20211202223214.72888-8-alexandr.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On Fri, Dec 03, 2021 at 11:03:35AM +0100, Ard Biesheuvel wrote: > On Fri, 3 Dec 2021 at 11:01, Peter Zijlstra wrote: > > > > On Thu, Dec 02, 2021 at 11:32:07PM +0100, Alexander Lobakin wrote: > > > From: Kristen Carlson Accardi > > > > > > This patch makes /proc/kallsyms display in a random order, rather > > > than sorted by address in order to hide the newly randomized address > > > layout. > > > > Is there a reason to not always do this? That is, why are we keeping two > > copies of this code around? Less code is more better etc.. > > +1. > > IIRC I made the exact same point when this patch was sent out by > Kristen a while ago. Yes. Alexander, I'd recommend going back to the review comments from Kristen's last posting, they may have been missed. -- Josh