live-patching.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: x86@kernel.org, Mark Rutland <mark.rutland@arm.com>,
	live-patching@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 0/6] x86,objtool: Split UNWIND_HINT_EMPTY in two
Date: Thu, 23 Mar 2023 13:38:17 +0100	[thread overview]
Message-ID: <20230323123817.GA2512024@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <cover.1677683419.git.jpoimboe@kernel.org>

On Wed, Mar 01, 2023 at 07:13:06AM -0800, Josh Poimboeuf wrote:
> Based on tip/objtool/core.
> 
> Mark reported that the ORC unwinder incorrectly marks an unwind as
> reliable when the unwind terminates prematurely in the dark corners of
> return_to_handler() due to lack of information about the next frame.
> 
> The problem is UNWIND_HINT_EMPTY is used in two different situations:
> end-of-stack marker and undefined stack state.
> 
> Split it up into UNWIND_HINT_END_OF_STACK and UNWIND_HINT_UNDEFINED.
> 
> Josh Poimboeuf (6):
>   objtool: Add objtool_types.h
>   objtool: Use relative pointers for annotations
>   objtool: Change UNWIND_HINT() argument order
>   x86,objtool: Introduce ORC_TYPE_*
>   x86,objtool: Separate unret validation from unwind hints
>   x86,objtool: Split UNWIND_HINT_EMPTY in two

Quite a bit of churn, but the end result does seem cleaner.

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

      parent reply	other threads:[~2023-03-23 12:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01 15:13 [PATCH 0/6] x86,objtool: Split UNWIND_HINT_EMPTY in two Josh Poimboeuf
2023-03-01 15:13 ` [PATCH 1/6] objtool: Add objtool_types.h Josh Poimboeuf
2023-03-01 15:13 ` [PATCH 2/6] objtool: Use relative pointers for annotations Josh Poimboeuf
2023-03-01 15:13 ` [PATCH 3/6] objtool: Change UNWIND_HINT() argument order Josh Poimboeuf
2023-03-01 15:13 ` [PATCH 4/6] x86,objtool: Introduce ORC_TYPE_* Josh Poimboeuf
2023-03-01 15:13 ` [PATCH 5/6] x86,objtool: Separate unret validation from unwind hints Josh Poimboeuf
2023-03-01 15:13 ` [PATCH 6/6] x86,objtool: Split UNWIND_HINT_EMPTY in two Josh Poimboeuf
2023-03-01 17:34   ` Steven Rostedt
2023-03-23 12:38 ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230323123817.GA2512024@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=jpoimboe@kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rostedt@goodmis.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).