From: shuah <shuah@kernel.org>
To: Joe Lawrence <joe.lawrence@redhat.com>,
live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
shuah <shuah@kernel.org>
Subject: Re: [PATCH] selftests/livepatch: add test skip handling
Date: Sat, 20 Jul 2019 05:26:19 -0600 [thread overview]
Message-ID: <215509dd-27d9-244a-870b-69df69fef38a@kernel.org> (raw)
In-Reply-To: <42feff41-8a92-e252-0e90-5c0335547de1@redhat.com>
On 7/19/19 8:51 PM, Joe Lawrence wrote:
> On 7/19/19 6:11 PM, shuah wrote:
>> On 7/14/19 8:33 AM, Joe Lawrence wrote:
>>> On Sun, Jul 14, 2019 at 10:28:29AM -0400, Joe Lawrence wrote:
>>>
> >> [ ... snip ... ]
>>>
>>> Testing:
>>>
>>> Here's the output if modprobe --dry-run doesn't like the modules (not
>>> built, etc.):
>>>
>>> TAP version 13
>>> selftests: livepatch: test-livepatch.sh
>>> ========================================
>>> SKIP: Failed modprobe --dry-run of module: test_klp_livepatch
>>> not ok 1..1 selftests: livepatch: test-livepatch.sh [SKIP]
>>> selftests: livepatch: test-callbacks.sh
>>> ========================================
>>> SKIP: Failed modprobe --dry-run of module: test_klp_callbacks_demo
>>> not ok 1..2 selftests: livepatch: test-callbacks.sh [SKIP]
>>> selftests: livepatch: test-shadow-vars.sh
>>> ========================================
>>> SKIP: Failed modprobe --dry-run of module: test_klp_shadow_vars
>>> not ok 1..3 selftests: livepatch: test-shadow-vars.sh [SKIP]
>>>
>>
>> Please refine these messages to say what users should do. In addition
>> to what failed, also add what is missing - enable config option etc.
>>
>
> Hi Shuah,
>
> Note that v2 was posted [1], but the output remains basically the same,
> so your comments still apply.
>
> Off the top of my head, modprobe can fail for many reasons: unprivileged
> user, missing .ko files, missing modules.dep entry, kernel vermagic,
> interface versions, etc.
>
> What would you think about modifying our skip() function to provide a
> catch-all list of CONFIG, environment, etc. requirements? Something
> like, "Please ensure that the kernel was build with CONFIG_XYZ and that
> the tests are run with foo privileges"? That would let us avoid trying
> to figure out exactly why the modprobe failed, but still help out the user.
>
I understand. I am not suggesting that you have to figure out why. I am
suggesting that instead of "Failed modprobe --dry-run of module", say
"Unable to load test_klp_shadow_vars module. Check if config option is
enabled" which is user friendly compared to the current message.
thanks,
-- Shuah
next prev parent reply other threads:[~2019-07-20 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 14:28 [PATCH] selftests/livepatch: add test skip handling Joe Lawrence
2019-07-14 14:33 ` Joe Lawrence
2019-07-15 11:17 ` Miroslav Benes
2019-07-19 22:11 ` shuah
2019-07-20 2:51 ` Joe Lawrence
2019-07-20 11:26 ` shuah [this message]
2019-07-15 6:50 ` Kamalesh Babulal
2019-07-15 14:09 ` Joe Lawrence
2019-07-16 13:13 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=215509dd-27d9-244a-870b-69df69fef38a@kernel.org \
--to=shuah@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).