Live-Patching Archive on
 help / color / Atom feed
From: shuah <>
To: Joe Lawrence <>
	shuah <>
Subject: Re: [RFC PATCH] selftests/livepatch: only consider supported arches
Date: Fri, 12 Jul 2019 12:14:56 -0600
Message-ID: <> (raw)
In-Reply-To: <>

On 7/12/19 11:58 AM, Joe Lawrence wrote:
> On Fri, Jul 12, 2019 at 11:43:02AM -0600, shuah wrote:
>> Hi Joe,
>> [ ... snip ... ]
>> The one thing I am not seeing is Skip handling. Without that users will
>> complain livepatch test is failing as opposed to that the test can't
>> run due to unmet dependencies and skipped.
>> Maybe that is all you need? I would recommend going in that direction
>> instead of Arch check.
> Okay, I see that kselftest/ compares test return code with
> skip_rc=4 to determine SKIP status... so perhaps our scripts could
> perform a simple "modinfo" on their test modules to determine if they
> have been built and installed?  If not found, just SKIP to the next
> test.

Yes. That would fix the problem.

tools/testing/selftests/ has hooks to help you
with modules checks. e.g: assert_have_module

-- Shuah

      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12 17:14 Joe Lawrence
2019-07-12 17:25 ` Joe Lawrence
2019-07-12 17:43   ` shuah
2019-07-12 17:58     ` Joe Lawrence
2019-07-12 18:14       ` shuah [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Live-Patching Archive on

Archives are clonable:
	git clone --mirror live-patching/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 live-patching live-patching/ \
	public-inbox-index live-patching

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone