From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF99C433F5 for ; Sat, 23 Oct 2021 12:49:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55E6160FC4 for ; Sat, 23 Oct 2021 12:49:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230088AbhJWMvf (ORCPT ); Sat, 23 Oct 2021 08:51:35 -0400 Received: from linux.microsoft.com ([13.77.154.182]:55314 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbhJWMvc (ORCPT ); Sat, 23 Oct 2021 08:51:32 -0400 Received: from [192.168.254.32] (unknown [47.187.212.181]) by linux.microsoft.com (Postfix) with ESMTPSA id A0CEE2064891; Sat, 23 Oct 2021 05:49:12 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A0CEE2064891 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1634993353; bh=xFXuz9rWSnTF5MnVRUBihVdw9KXSz2G2i8s+MV54MGs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MyYom8geXOg8HqEQJRagVh7NRn+nyAPArhhuQaY/De8NjNB2y0l9ZS65Kb0yJi+3J m/dLNcPFaiFEDL+OLyYWU57lThwPyNP/x4RcF23n8y3Q0rJKhFsCKDjWWejTi0ntM1 kyHpKu3qL9Ucxc5YoduFkndzjlQiFdqggCnvYlyY= Subject: Re: [PATCH v10 02/11] arm64: Make perf_callchain_kernel() use arch_stack_walk() To: Mark Rutland Cc: broonie@kernel.org, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211015025847.17694-1-madvenka@linux.microsoft.com> <20211015025847.17694-3-madvenka@linux.microsoft.com> <20211022181154.GM86184@C02TD0UTHF1T.local> From: "Madhavan T. Venkataraman" Message-ID: <4de6800b-54fc-a74d-598f-80fc40924976@linux.microsoft.com> Date: Sat, 23 Oct 2021 07:49:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211022181154.GM86184@C02TD0UTHF1T.local> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On 10/22/21 1:11 PM, Mark Rutland wrote: > On Thu, Oct 14, 2021 at 09:58:38PM -0500, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> >> Currently, perf_callchain_kernel() in ARM64 code walks the stack using >> start_backtrace() and walk_stackframe(). Make it use arch_stack_walk() >> instead. This makes maintenance easier. >> >> Signed-off-by: Madhavan T. Venkataraman > > This looks good to me; bailing out when perf_callchain_store() can't > accept any more entries absolutely makes sense. > > I gave this a spin with: > > | # perf record -g -c1 ls > | # perf report > > ... and the recorded callchains look sane. > > Reviewed-by: Mark Rutland > Tested-by: Mark Rutland > Thanks a lot! > As mentioned on patch 1, I'd like to get this rebased atop Peter's > untangling of ARCH_STACKWALK from STACKTRACE. > Will do. Thanks. Madhavan