From: Joe Lawrence <joe.lawrence@redhat.com>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
Miroslav Benes <mbenes@suse.cz>,
rostedt@goodmis.org, mingo@redhat.com, jpoimboe@redhat.com,
jikos@kernel.org, pmladek@suse.com
Cc: linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
shuah@kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v3 2/3] selftests/livepatch: Make dynamic debug setup and restore generic
Date: Wed, 16 Oct 2019 17:39:17 -0400 [thread overview]
Message-ID: <5def9a66-1029-e963-b44d-020791763f16@redhat.com> (raw)
In-Reply-To: <f50cf434-6dd2-51eb-a688-0da79d7ab8bc@linux.vnet.ibm.com>
On 10/16/19 1:10 PM, Kamalesh Babulal wrote:
> On 10/16/19 5:03 PM, Miroslav Benes wrote:
>> From: Joe Lawrence <joe.lawrence@redhat.com>
>>
>> Livepatch selftests currently save the current dynamic debug config and
>> tweak it for the selftests. The config is restored at the end. Make the
>> infrastructure generic, so that more variables can be saved and
>> restored.
>>
>> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
>> Signed-off-by: Miroslav Benes <mbenes@suse.cz>
>> ---
>> .../testing/selftests/livepatch/functions.sh | 22 +++++++++++--------
>> .../selftests/livepatch/test-callbacks.sh | 2 +-
>> .../selftests/livepatch/test-livepatch.sh | 2 +-
>> .../selftests/livepatch/test-shadow-vars.sh | 2 +-
>
> A minor nit pick, should the README also updated with the setup_config()?
>
Yup, good eye. I think it should be a simple matter of
s/set_dynamic_debug/setup_config/g
-- Joe
next prev parent reply other threads:[~2019-10-16 21:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 11:33 [PATCH v3 0/3] ftrace: Introduce PERMANENT ftrace_ops flag Miroslav Benes
2019-10-16 11:33 ` [PATCH v3 1/3] " Miroslav Benes
2019-10-16 13:48 ` Steven Rostedt
2019-10-16 14:25 ` Steven Rostedt
2019-10-16 11:33 ` [PATCH v3 2/3] selftests/livepatch: Make dynamic debug setup and restore generic Miroslav Benes
2019-10-16 15:08 ` Petr Mladek
2019-10-16 17:10 ` Kamalesh Babulal
2019-10-16 21:39 ` Joe Lawrence [this message]
2019-10-16 11:33 ` [PATCH v3 3/3] selftests/livepatch: Test interaction with ftrace_enabled Miroslav Benes
2019-10-16 15:07 ` Petr Mladek
2019-10-16 17:06 ` Kamalesh Babulal
2019-10-16 21:47 ` Joe Lawrence
2019-10-17 7:25 ` Kamalesh Babulal
2019-10-16 14:58 ` [PATCH v3 0/3] ftrace: Introduce PERMANENT ftrace_ops flag Steven Rostedt
2019-10-16 15:01 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5def9a66-1029-e963-b44d-020791763f16@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).