From: Joe Lawrence <joe.lawrence@redhat.com>
To: shuah <shuah@kernel.org>, Petr Mladek <pmladek@suse.com>
Cc: linux-kselftest@vger.kernel.org, live-patching@vger.kernel.org,
Jiri Benc <jbenc@redhat.com>
Subject: Re: [PATCH v3] selftests/livepatch: add test skip handling
Date: Wed, 24 Jul 2019 14:45:49 -0400 [thread overview]
Message-ID: <643f0d9f-ada1-da3d-7980-4f2df6a6e63f@redhat.com> (raw)
In-Reply-To: <0aae34cf-ae82-1f80-7bc9-27708c61287a@kernel.org>
On 07/24/2019 12:45 PM, shuah wrote:
> On 7/24/19 12:27 AM, Petr Mladek wrote:
>> On Mon 2019-07-22 10:05:44, Joe Lawrence wrote:
>>> Add a skip() message function that stops the test, logs an explanation,
>>> and sets the "skip" return code (4).
>>>
>>> Before loading a livepatch self-test kernel module, first verify that
>>> we've built and installed it by running a 'modprobe --dry-run'. This
>>> should catch a few environment issues, including !CONFIG_LIVEPATCH and
>>> !CONFIG_TEST_LIVEPATCH. In these cases, exit gracefully with the new
>>> skip() function.
>>>
>>> Reported-by: Jiri Benc <jbenc@redhat.com>
>>> Suggested-by: Shuah Khan <shuah@kernel.org>
>>> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
>>
>> Reviewed-by: Petr Mladek <pmladek@suse.com>
>>
>> Best Regards,
>> Petr
>>
>> PS: No need to send v4. The missing "to", suggested by Shuah, could
>> get added when pushing the patch into the repo.
>>
>
> I can't make changes to the patch. I can adjust the commit log at times
> and correct merge conflicts.
>
> I would like to see v4 for this.
>
We should clarify for which tree this and "[PATCH] selftests/livepatch:
push and pop dynamic debug config" would be merged. I had assumed this
would go to the livepatching tree, but Shuah, do you prefer that
selftest-centric patches go through the selftests tree?
I'm okay with either and can send up a v4 if needed. But also this
would be good to know for future changesets like this, we can perhaps
mark the destination branch in advance.
Thanks,
-- Joe
next prev parent reply other threads:[~2019-07-24 18:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 14:05 [PATCH v3] selftests/livepatch: add test skip handling Joe Lawrence
2019-07-23 15:53 ` shuah
2019-07-24 20:05 ` [PATCH v4] " Joe Lawrence
2019-07-24 20:19 ` shuah
2019-07-24 6:27 ` [PATCH v3] " Petr Mladek
2019-07-24 16:45 ` shuah
2019-07-24 18:45 ` Joe Lawrence [this message]
2019-07-24 19:51 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=643f0d9f-ada1-da3d-7980-4f2df6a6e63f@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=jbenc@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).