From: Allen <allen.lkml@gmail.com>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Christoph Lameter <cl@linux.com>, Petr Mladek <pmladek@suse.com>,
Miroslav Benes <mbenes@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
jeyu@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-modules@vger.kernel.org, live-patching@vger.kernel.org,
atomlin@atomlin.com, ghalat@redhat.com, void@manifault.com,
Joe Perches <joe@perches.com>
Subject: Re: [RFC PATCH v4 00/13] module: core code clean up
Date: Tue, 1 Feb 2022 08:44:21 -0800 [thread overview]
Message-ID: <CAOMdWS+PDCNO3mpGOU-521mWcMwQW0R4iacsWPkgGZL0aYbxrw@mail.gmail.com> (raw)
In-Reply-To: <20220130213214.1042497-1-atomlin@redhat.com>
Thanks Aaron for V4.
Build/boot test on qemu. Running more tests on BM.
Thanks.
On Sun, Jan 30, 2022 at 1:32 PM Aaron Tomlin <atomlin@redhat.com> wrote:
>
> Hi Luis,
>
> As per your suggestion [1], this is an attempt to refactor and split
> optional code out of core module support code into separate components.
> This version is based on branch mcgrof/modules-next since a97ac8cb24a3/or
> modules-5.17-rc1. Please let me know your thoughts.
>
> Changes since v1 [2]:
>
> - Moved module version support code into a new file
>
> Changes since v2 [3]:
>
> - Moved module decompress support to a separate file
> - Made check_modinfo_livepatch() generic (Petr Mladek)
> - Removed filename from each newly created file (Luis Chamberlain)
> - Addressed some (i.e. --ignore=ASSIGN_IN_IF,AVOID_BUG was used)
> minor scripts/checkpatch.pl concerns e.g., use strscpy over
> strlcpy and missing a blank line after declarations (Allen)
>
> Changes since v3 [4]:
>
> - Refactored both is_livepatch_module() and set_livepatch_module(),
> respectively, to use IS_ENABLED(CONFIG_LIVEPATCH) (Joe Perches)
> - Addressed various compiler warnings e.g., no previous prototype (0-day)
>
> [1]: https://lore.kernel.org/lkml/YbEZ4HgSYQEPuRmS@bombadil.infradead.org/
> [2]: https://lore.kernel.org/lkml/20211228213041.1356334-1-atomlin@redhat.com/
> [3]: https://lore.kernel.org/lkml/20220106234319.2067842-1-atomlin@redhat.com/
> [4]: https://lore.kernel.org/lkml/20220128203934.600247-1-atomlin@redhat.com/
>
> Aaron Tomlin (13):
> module: Move all into module/
> module: Simple refactor in preparation for split
> module: Move livepatch support to a separate file
> module: Move latched RB-tree support to a separate file
> module: Move arch strict rwx support to a separate file
> module: Move strict rwx support to a separate file
> module: Move extra signature support out of core code
> module: Move kmemleak support to a separate file
> module: Move kallsyms support into a separate file
> module: Move procfs support into a separate file
> module: Move sysfs support into a separate file
> module: Move kdb_modules list out of core code
> module: Move version support into a separate file
>
> MAINTAINERS | 2 +-
> include/linux/module.h | 64 +-
> kernel/Makefile | 5 +-
> kernel/debug/kdb/kdb_main.c | 5 +
> kernel/module-internal.h | 50 -
> kernel/module/Makefile | 20 +
> kernel/module/arch_strict_rwx.c | 44 +
> kernel/module/debug_kmemleak.c | 30 +
> .../decompress.c} | 2 +-
> kernel/module/internal.h | 236 +++
> kernel/module/kallsyms.c | 502 +++++
> kernel/module/livepatch.c | 74 +
> kernel/{module.c => module/main.c} | 1874 +----------------
> kernel/module/procfs.c | 142 ++
> .../signature.c} | 0
> kernel/module/signing.c | 120 ++
> kernel/module/strict_rwx.c | 83 +
> kernel/module/sysfs.c | 425 ++++
> kernel/module/tree_lookup.c | 109 +
> kernel/module/version.c | 110 +
> kernel/module_signing.c | 45 -
> 21 files changed, 2038 insertions(+), 1904 deletions(-)
> delete mode 100644 kernel/module-internal.h
> create mode 100644 kernel/module/Makefile
> create mode 100644 kernel/module/arch_strict_rwx.c
> create mode 100644 kernel/module/debug_kmemleak.c
> rename kernel/{module_decompress.c => module/decompress.c} (99%)
> create mode 100644 kernel/module/internal.h
> create mode 100644 kernel/module/kallsyms.c
> create mode 100644 kernel/module/livepatch.c
> rename kernel/{module.c => module/main.c} (63%)
> create mode 100644 kernel/module/procfs.c
> rename kernel/{module_signature.c => module/signature.c} (100%)
> create mode 100644 kernel/module/signing.c
> create mode 100644 kernel/module/strict_rwx.c
> create mode 100644 kernel/module/sysfs.c
> create mode 100644 kernel/module/tree_lookup.c
> create mode 100644 kernel/module/version.c
> delete mode 100644 kernel/module_signing.c
>
>
> base-commit: a97ac8cb24a3c3ad74794adb83717ef1605d1b47
> --
> 2.34.1
>
--
- Allen
next prev parent reply other threads:[~2022-02-01 16:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 21:32 [RFC PATCH v4 00/13] module: core code clean up Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 01/13] module: Move all into module/ Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 02/13] module: Simple refactor in preparation for split Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 03/13] module: Move livepatch support to a separate file Aaron Tomlin
2022-02-08 11:42 ` Petr Mladek
2022-02-08 15:18 ` Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 04/13] module: Move latched RB-tree " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 05/13] module: Move arch strict rwx " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 06/13] module: Move " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 07/13] module: Move extra signature support out of core code Aaron Tomlin
2022-02-09 14:28 ` Miroslav Benes
2022-02-09 14:37 ` Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 08/13] module: Move kmemleak support to a separate file Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 09/13] module: Move kallsyms support into " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 10/13] module: Move procfs " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 11/13] module: Move sysfs " Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 12/13] module: Move kdb_modules list out of core code Aaron Tomlin
2022-01-30 21:32 ` [RFC PATCH v4 13/13] module: Move version support into a separate file Aaron Tomlin
2022-02-01 16:44 ` Allen [this message]
2022-02-05 20:33 ` [RFC PATCH v4 00/13] module: core code clean up Aaron Tomlin
2022-02-02 2:44 ` Luis Chamberlain
2022-02-06 14:40 ` Aaron Tomlin
2022-02-03 0:20 ` Luis Chamberlain
2022-02-03 7:48 ` Christophe Leroy
2022-02-06 14:45 ` Aaron Tomlin
2022-02-03 18:01 ` Christophe Leroy
2022-02-06 16:54 ` Aaron Tomlin
2022-02-07 16:46 ` Aaron Tomlin
2022-02-07 17:17 ` Christophe Leroy
2022-02-07 18:01 ` Aaron Tomlin
2022-02-08 7:50 ` Christophe Leroy
2022-02-08 10:05 ` Aaron Tomlin
2022-02-03 18:15 ` Christophe Leroy
2022-02-06 16:57 ` Aaron Tomlin
2022-02-03 19:43 ` Michal Suchánek
2022-02-03 20:13 ` Luis Chamberlain
2022-02-03 20:10 ` Luis Chamberlain
2022-02-06 17:00 ` Aaron Tomlin
2022-02-06 14:42 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMdWS+PDCNO3mpGOU-521mWcMwQW0R4iacsWPkgGZL0aYbxrw@mail.gmail.com \
--to=allen.lkml@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=atomlin@atomlin.com \
--cc=atomlin@redhat.com \
--cc=cl@linux.com \
--cc=ghalat@redhat.com \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=pmladek@suse.com \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).