[PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary gaps in a sentence

[PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary gaps in a sentence

[Bhaskar Chowdhury]

s/varibles/variables/

...and remove leading spaces from a sentence.

Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
 Changes from V1:
  Pter pointed out some awkward  leading space in a sentence ,fixed it.

 Documentation/livepatch/shadow-vars.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/livepatch/shadow-vars.rst b/Documentation/livepatch/shadow-vars.rst
index c05715aeafa4..2ee114a91a35 100644
--- a/Documentation/livepatch/shadow-vars.rst
+++ b/Documentation/livepatch/shadow-vars.rst
@@ -165,8 +165,8 @@ In-flight parent objects

 Sometimes it may not be convenient or possible to allocate shadow
 variables alongside their parent objects.  Or a livepatch fix may
-require shadow varibles to only a subset of parent object instances.  In
-these cases, the klp_shadow_get_or_alloc() call can be used to attach
+require shadow variables to only a subset of parent object instances.
+In these cases, the klp_shadow_get_or_alloc() call can be used to attach
 shadow variables to parents already in-flight.

 For commit 1d147bfa6429, a good spot to allocate a shadow spinlock is
--
2.20.1

Re: [PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary gaps in a sentence

[Matthew Wilcox]

On Fri, Mar 05, 2021 at 03:39:23PM +0530, Bhaskar Chowdhury wrote:
> s/varibles/variables/
> 
> ...and remove leading spaces from a sentence.

What do you mean 'leading spaces'?  Separating two sentences with
one space or two is a matter of personal style, and we do not attempt
to enforce a particular style in the kernel.

>  Sometimes it may not be convenient or possible to allocate shadow
>  variables alongside their parent objects.  Or a livepatch fix may
> -require shadow varibles to only a subset of parent object instances.  In
> +require shadow variables to only a subset of parent object instances.

wrong preposition, s/to/for/

Re: [PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary gaps in a sentence

[Bhaskar Chowdhury]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

On 12:56 Fri 05 Mar 2021, Matthew Wilcox wrote:
>On Fri, Mar 05, 2021 at 03:39:23PM +0530, Bhaskar Chowdhury wrote:
>> s/varibles/variables/
>>
>> ...and remove leading spaces from a sentence.
>
>What do you mean 'leading spaces'?  Separating two sentences with
>one space or two is a matter of personal style, and we do not attempt
>to enforce a particular style in the kernel.
>
The spaces before the "In" .. nor I am imposing anything , it was peter caught
and told me that it is hanging ..move it to the next line ..so I did. ..

>>  Sometimes it may not be convenient or possible to allocate shadow
>>  variables alongside their parent objects.  Or a livepatch fix may
>> -require shadow varibles to only a subset of parent object instances.  In
>> +require shadow variables to only a subset of parent object instances.
>
>wrong preposition, s/to/for/    ..where???

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary gaps in a sentence

[Joe Lawrence]

On 3/5/21 8:37 AM, Bhaskar Chowdhury wrote:
> On 12:56 Fri 05 Mar 2021, Matthew Wilcox wrote:
>> On Fri, Mar 05, 2021 at 03:39:23PM +0530, Bhaskar Chowdhury wrote:
>>> s/varibles/variables/
>>>
>>> ...and remove leading spaces from a sentence.
>>
>> What do you mean 'leading spaces'?  Separating two sentences with
>> one space or two is a matter of personal style, and we do not attempt
>> to enforce a particular style in the kernel.
>>
> The spaces before the "In" .. nor I am imposing anything , it was peter caught
> and told me that it is hanging ..move it to the next line ..so I did. ..
> 

Initially I thought the same as Matthew, but after inspecting the diff I 
realized it was just a line wrap.  Looks fine to me.

>>>   Sometimes it may not be convenient or possible to allocate shadow
>>>   variables alongside their parent objects.  Or a livepatch fix may
>>> -require shadow varibles to only a subset of parent object instances.  In
>>> +require shadow variables to only a subset of parent object instances.
>>
>> wrong preposition, s/to/for/    ..where???

Hi Bhaskar,

Thanks for spotting, I'd be happy with v2 as is or a v3 if you want to 
update s/shadow variables to only/shadow variables for only/  but 
knowing me, I probably repeated the same phrasing elsewhere.  Up to you, 
thanks.

Acked-by: Joe Lawrence <joe.lawrence@redhat.com>

-- Joe

Re: [PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary gaps in a sentence

[Petr Mladek]

On Fri 2021-03-05 11:00:10, Joe Lawrence wrote:
> On 3/5/21 8:37 AM, Bhaskar Chowdhury wrote:
> > On 12:56 Fri 05 Mar 2021, Matthew Wilcox wrote:
> > > On Fri, Mar 05, 2021 at 03:39:23PM +0530, Bhaskar Chowdhury wrote:
> > > > s/varibles/variables/
> > > > 
> > > > ...and remove leading spaces from a sentence.
> > > 
> > > What do you mean 'leading spaces'?  Separating two sentences with
> > > one space or two is a matter of personal style, and we do not attempt
> > > to enforce a particular style in the kernel.
> > > 
> > The spaces before the "In" .. nor I am imposing anything , it was peter caught
> > and told me that it is hanging ..move it to the next line ..so I did. ..
> > 
> 
> Initially I thought the same as Matthew, but after inspecting the diff I
> realized it was just a line wrap.  Looks fine to me.
> 
> > > >   Sometimes it may not be convenient or possible to allocate shadow
> > > >   variables alongside their parent objects.  Or a livepatch fix may
> > > > -require shadow varibles to only a subset of parent object instances.  In
> > > > +require shadow variables to only a subset of parent object instances.
> > > 
> > > wrong preposition, s/to/for/    ..where???
> 
> Hi Bhaskar,
> 
> Thanks for spotting, I'd be happy with v2 as is or a v3 if you want to
> update s/shadow variables to only/shadow variables for only/  but knowing
> me, I probably repeated the same phrasing elsewhere.  Up to you, thanks.

I could fix these when pushing unless anyone is against it.

> Acked-by: Joe Lawrence <joe.lawrence@redhat.com>

Acked-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

Re: [PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary gaps in a sentence

[Jonathan Corbet]

Bhaskar Chowdhury <unixbhaskar@gmail.com> writes:

> s/varibles/variables/
>
> ...and remove leading spaces from a sentence.
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
>  Changes from V1:
>   Pter pointed out some awkward  leading space in a sentence ,fixed it.
>
>  Documentation/livepatch/shadow-vars.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I've applied this, poking in the suggested prepositional tweak in the
process.

Thanks,

jon