From: Petr Mladek <email@example.com>
To: Joe Lawrence <firstname.lastname@example.org>
Cc: Bhaskar Chowdhury <email@example.com>,
Matthew Wilcox <firstname.lastname@example.org>,
email@example.com, firstname.lastname@example.org, email@example.com,
Subject: Re: [PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary gaps in a sentence
Date: Mon, 8 Mar 2021 11:18:50 +0100 [thread overview]
Message-ID: <YEX6Cu0EcVpUklFG@alley> (raw)
On Fri 2021-03-05 11:00:10, Joe Lawrence wrote:
> On 3/5/21 8:37 AM, Bhaskar Chowdhury wrote:
> > On 12:56 Fri 05 Mar 2021, Matthew Wilcox wrote:
> > > On Fri, Mar 05, 2021 at 03:39:23PM +0530, Bhaskar Chowdhury wrote:
> > > > s/varibles/variables/
> > > >
> > > > ...and remove leading spaces from a sentence.
> > >
> > > What do you mean 'leading spaces'? Separating two sentences with
> > > one space or two is a matter of personal style, and we do not attempt
> > > to enforce a particular style in the kernel.
> > >
> > The spaces before the "In" .. nor I am imposing anything , it was peter caught
> > and told me that it is hanging ..move it to the next line ..so I did. ..
> Initially I thought the same as Matthew, but after inspecting the diff I
> realized it was just a line wrap. Looks fine to me.
> > > > Sometimes it may not be convenient or possible to allocate shadow
> > > > variables alongside their parent objects. Or a livepatch fix may
> > > > -require shadow varibles to only a subset of parent object instances. In
> > > > +require shadow variables to only a subset of parent object instances.
> > >
> > > wrong preposition, s/to/for/ ..where???
> Hi Bhaskar,
> Thanks for spotting, I'd be happy with v2 as is or a v3 if you want to
> update s/shadow variables to only/shadow variables for only/ but knowing
> me, I probably repeated the same phrasing elsewhere. Up to you, thanks.
I could fix these when pushing unless anyone is against it.
> Acked-by: Joe Lawrence <firstname.lastname@example.org>
Acked-by: Petr Mladek <email@example.com>
next prev parent reply other threads:[~2021-03-08 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 10:09 [PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary gaps in a sentence Bhaskar Chowdhury
2021-03-05 12:56 ` Matthew Wilcox
2021-03-05 13:37 ` Bhaskar Chowdhury
2021-03-05 16:00 ` Joe Lawrence
2021-03-08 10:18 ` Petr Mladek [this message]
2021-03-09 0:26 ` Jonathan Corbet
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).