live-patching.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] livepatch: Replace the fake signal sending with TIF_NOTIFY_SIGNAL infrastructure
@ 2021-03-26 14:30 Miroslav Benes
  2021-03-26 23:10 ` Jens Axboe
  2021-03-29 12:25 ` Petr Mladek
  0 siblings, 2 replies; 3+ messages in thread
From: Miroslav Benes @ 2021-03-26 14:30 UTC (permalink / raw)
  To: jpoimboe, jikos, pmladek, joe.lawrence
  Cc: live-patching, linux-kernel, axboe, Miroslav Benes

Livepatch sends a fake signal to all remaining blocking tasks of a
running transition after a set period of time. It uses TIF_SIGPENDING
flag for the purpose. Commit 12db8b690010 ("entry: Add support for
TIF_NOTIFY_SIGNAL") added a generic infrastructure to achieve the same.
Replace our bespoke solution with the generic one.

Signed-off-by: Miroslav Benes <mbenes@suse.cz>
---
Tested on x86_64, s390x and ppc64le archs.

 kernel/livepatch/transition.c | 5 ++---
 kernel/signal.c               | 3 +--
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c
index f6310f848f34..3a4beb9395c4 100644
--- a/kernel/livepatch/transition.c
+++ b/kernel/livepatch/transition.c
@@ -9,6 +9,7 @@
 
 #include <linux/cpu.h>
 #include <linux/stacktrace.h>
+#include <linux/tracehook.h>
 #include "core.h"
 #include "patch.h"
 #include "transition.h"
@@ -369,9 +370,7 @@ static void klp_send_signals(void)
 			 * Send fake signal to all non-kthread tasks which are
 			 * still not migrated.
 			 */
-			spin_lock_irq(&task->sighand->siglock);
-			signal_wake_up(task, 0);
-			spin_unlock_irq(&task->sighand->siglock);
+			set_notify_signal(task);
 		}
 	}
 	read_unlock(&tasklist_lock);
diff --git a/kernel/signal.c b/kernel/signal.c
index f2a1b898da29..e52cb82aaecd 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -181,8 +181,7 @@ void recalc_sigpending_and_wake(struct task_struct *t)
 
 void recalc_sigpending(void)
 {
-	if (!recalc_sigpending_tsk(current) && !freezing(current) &&
-	    !klp_patch_pending(current))
+	if (!recalc_sigpending_tsk(current) && !freezing(current))
 		clear_thread_flag(TIF_SIGPENDING);
 
 }
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] livepatch: Replace the fake signal sending with TIF_NOTIFY_SIGNAL infrastructure
  2021-03-26 14:30 [PATCH] livepatch: Replace the fake signal sending with TIF_NOTIFY_SIGNAL infrastructure Miroslav Benes
@ 2021-03-26 23:10 ` Jens Axboe
  2021-03-29 12:25 ` Petr Mladek
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-03-26 23:10 UTC (permalink / raw)
  To: Miroslav Benes, jpoimboe, jikos, pmladek, joe.lawrence
  Cc: live-patching, linux-kernel

On 3/26/21 8:30 AM, Miroslav Benes wrote:
> Livepatch sends a fake signal to all remaining blocking tasks of a
> running transition after a set period of time. It uses TIF_SIGPENDING
> flag for the purpose. Commit 12db8b690010 ("entry: Add support for
> TIF_NOTIFY_SIGNAL") added a generic infrastructure to achieve the same.
> Replace our bespoke solution with the generic one.
> 
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>

Looks good to me.

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] livepatch: Replace the fake signal sending with TIF_NOTIFY_SIGNAL infrastructure
  2021-03-26 14:30 [PATCH] livepatch: Replace the fake signal sending with TIF_NOTIFY_SIGNAL infrastructure Miroslav Benes
  2021-03-26 23:10 ` Jens Axboe
@ 2021-03-29 12:25 ` Petr Mladek
  1 sibling, 0 replies; 3+ messages in thread
From: Petr Mladek @ 2021-03-29 12:25 UTC (permalink / raw)
  To: Miroslav Benes
  Cc: jpoimboe, jikos, joe.lawrence, live-patching, linux-kernel, axboe

On Fri 2021-03-26 15:30:21, Miroslav Benes wrote:
> Livepatch sends a fake signal to all remaining blocking tasks of a
> running transition after a set period of time. It uses TIF_SIGPENDING
> flag for the purpose. Commit 12db8b690010 ("entry: Add support for
> TIF_NOTIFY_SIGNAL") added a generic infrastructure to achieve the same.
> Replace our bespoke solution with the generic one.
> 
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>
> ---
> Tested on x86_64, s390x and ppc64le archs.
> 
>  kernel/livepatch/transition.c | 5 ++---
>  kernel/signal.c               | 3 +--
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c
> index f6310f848f34..3a4beb9395c4 100644
> --- a/kernel/livepatch/transition.c
> +++ b/kernel/livepatch/transition.c
> @@ -9,6 +9,7 @@
>  
>  #include <linux/cpu.h>
>  #include <linux/stacktrace.h>
> +#include <linux/tracehook.h>
>  #include "core.h"
>  #include "patch.h"
>  #include "transition.h"
> @@ -369,9 +370,7 @@ static void klp_send_signals(void)
>  			 * Send fake signal to all non-kthread tasks which are
>  			 * still not migrated.
>  			 */
> -			spin_lock_irq(&task->sighand->siglock);
> -			signal_wake_up(task, 0);
> -			spin_unlock_irq(&task->sighand->siglock);
> +			set_notify_signal(task);
>  		}
>  	}
>  	read_unlock(&tasklist_lock);
> diff --git a/kernel/signal.c b/kernel/signal.c
> index f2a1b898da29..e52cb82aaecd 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -181,8 +181,7 @@ void recalc_sigpending_and_wake(struct task_struct *t)
>  
>  void recalc_sigpending(void)
>  {
> -	if (!recalc_sigpending_tsk(current) && !freezing(current) &&
> -	    !klp_patch_pending(current))
> +	if (!recalc_sigpending_tsk(current) && !freezing(current))
>  		clear_thread_flag(TIF_SIGPENDING);
>  
>  }

The original commit 43347d56c8d9dd732cee2 ("livepatch: send a fake
signal to all blocking tasks") did also:

--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -40,6 +40,7 @@
 #include <linux/cn_proc.h>
 #include <linux/compiler.h>
 #include <linux/posix-timers.h>
+#include <linux/livepatch.h>
 
 #define CREATE_TRACE_POINTS
 #include <trace/events/signal.h>

We could/should remove the include now.

Otherwise, it looks good to me. Well, I do not feel to be expert
in this are. Anyway, feel free to add:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-29 12:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 14:30 [PATCH] livepatch: Replace the fake signal sending with TIF_NOTIFY_SIGNAL infrastructure Miroslav Benes
2021-03-26 23:10 ` Jens Axboe
2021-03-29 12:25 ` Petr Mladek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).