From: Petr Mladek <pmladek@suse.com>
To: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>, Jiri Kosina <jikos@kernel.org>,
Miroslav Benes <mbenes@suse.cz>,
Joe Lawrence <joe.lawrence@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Heiko Carstens <hca@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Sumanth Korikkar <sumanthk@linux.ibm.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] livepatch: Fix idle cpu's tasks transition
Date: Mon, 20 Sep 2021 10:27:57 +0200 [thread overview]
Message-ID: <YUhGDXzg2VhycKlR@alley> (raw)
In-Reply-To: <patch.git-94c1daf66a9c.your-ad-here.call-01631714463-ext-3692@work.hours>
On Wed 2021-09-15 16:18:01, Vasily Gorbik wrote:
> On an idle system with large amount of cpus it might happen that
> klp_update_patch_state() is not reached in do_idle() for a long periods
> of time. With debug messages enabled log is filled with:
> [ 499.442643] livepatch: klp_try_switch_task: swapper/63:0 is running
>
> without any signs of progress. Ending up with "failed to complete
> transition".
>
> On s390 LPAR with 128 cpus not a single transition is able to complete
> and livepatch kselftests fail. Tests on idling x86 kvm instance with 128
> cpus demonstrate similar symptoms with and without CONFIG_NO_HZ.
>
> To deal with that, since runqueue is already locked in
> klp_try_switch_task() identify idling cpus and trigger rescheduling
> potentially waking them up and making sure idle tasks break out of
> do_idle() inner loop and reach klp_update_patch_state(). This helps to
> speed up transition time while avoiding unnecessary extra system load.
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> Acked-by: Miroslav Benes <mbenes@suse.cz>
> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> ---
> Ingo/Peter, as Josh mentioned, could you please ack if you are ok with
> livepatch calling this private scheduler interface?
Ingo, Peter, Josh, could anyone please ack that it is acceptable
to call resched_curr(rq) from the livepatch code?
Or is there a better way to make an idle task go through
the main cycle?
Best Regards,
Petr
>
> Changes since v1:
> - added comments suggested by Petr
> lkml.kernel.org/r/patch.git-a4aad6b1540d.your-ad-here.call-01631177886-ext-3083@work.hours
>
> Previous discussion and RFC PATCH:
> lkml.kernel.org/r/patch.git-b76842ceb035.your-ad-here.call-01625661932-ext-1304@work.hours
>
> kernel/livepatch/transition.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c
> index 291b857a6e20..2846a879f2dc 100644
> --- a/kernel/livepatch/transition.c
> +++ b/kernel/livepatch/transition.c
> @@ -278,6 +278,8 @@ static int klp_check_stack(struct task_struct *task, char *err_buf)
> * Try to safely switch a task to the target patch state. If it's currently
> * running, or it's sleeping on a to-be-patched or to-be-unpatched function, or
> * if the stack is unreliable, return false.
> + *
> + * Idle tasks are switched in the main loop when running.
> */
> static bool klp_try_switch_task(struct task_struct *task)
> {
> @@ -308,6 +310,12 @@ static bool klp_try_switch_task(struct task_struct *task)
> rq = task_rq_lock(task, &flags);
>
> if (task_running(rq, task) && task != current) {
> + /*
> + * Idle task might stay running for a long time. Switch them
> + * in the main loop.
> + */
> + if (is_idle_task(task))
> + resched_curr(rq);
> snprintf(err_buf, STACK_ERR_BUF_SIZE,
> "%s: %s:%d is running\n", __func__, task->comm,
> task->pid);
> --
> 2.25.4
next prev parent reply other threads:[~2021-09-20 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 14:18 [PATCH v2] livepatch: Fix idle cpu's tasks transition Vasily Gorbik
2021-09-20 8:27 ` Petr Mladek [this message]
2021-09-21 17:43 ` Peter Zijlstra
2021-09-21 21:17 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUhGDXzg2VhycKlR@alley \
--to=pmladek@suse.com \
--cc=fweisbec@gmail.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sumanthk@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).