From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B2D2C433FF for ; Tue, 13 Aug 2019 14:02:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69130206C2 for ; Tue, 13 Aug 2019 14:02:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729180AbfHMOCY (ORCPT ); Tue, 13 Aug 2019 10:02:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:36028 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728095AbfHMOCY (ORCPT ); Tue, 13 Aug 2019 10:02:24 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E0524AD95; Tue, 13 Aug 2019 14:02:22 +0000 (UTC) Date: Tue, 13 Aug 2019 16:02:17 +0200 (CEST) From: Miroslav Benes To: Josh Poimboeuf cc: Joe Lawrence , heiko.carstens@de.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, jikos@kernel.org, pmladek@suse.com, nstange@suse.de, live-patching@vger.kernel.org Subject: Re: [PATCH] s390/livepatch: Implement reliable stack tracing for the consistency model In-Reply-To: <20190728203053.q3pafkwnzm5j3ccs@treble> Message-ID: References: <20190710105918.22487-1-mbenes@suse.cz> <20190716184549.GA26084@redhat.com> <20190728203053.q3pafkwnzm5j3ccs@treble> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: live-patching-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On Sun, 28 Jul 2019, Josh Poimboeuf wrote: > On Wed, Jul 17, 2019 at 01:01:27PM +0200, Miroslav Benes wrote: > > > On a related note, do you think it would be feasible to extend (in > > > another patchset) the reliable stack unwinding code a bit so that we > > > could feed it pre-baked stacks ... then we could verify that the code > > > was finding interesting scenarios. That was a passing thought I had > > > back when Nicolai and I were debugging the ppc64le exception frame > > > marker bug, but didn't think it worth the time/effort at the time. > > > > That is an interesting thought. It would help the testing a lot. I will > > make a note in my todo list. > > Another idea I had for reliable unwinder testing: add a > CONFIG_RELIABLE_STACKTRACE_DEBUG option which does a periodic stack > trace and warns if it doesn't reach the end. It could triggered from a > periodic NMI, or from schedule(). Noted as well. Miroslav