From: Miroslav Benes <mbenes@suse.cz>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
live-patching@vger.kernel.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules
Date: Tue, 20 Aug 2019 09:54:05 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.21.1908200948260.9536@pobox.suse.cz> (raw)
In-Reply-To: <9127bdf6-1daf-0387-88fb-6f1118dd6804@redhat.com>
> > How is this feature supposed to work for external modules?
> >
> > klp-convert receives:
> > "symbols from vmlinux" + "symbols from no-klp in-tree modules"
> > + "symbols from no-klp external modules" ??
> >
>
> I don't think that this use-case has been previously thought out (Miroslav,
> correct me if I'm wrong here.)
>
> I did just run an external build of a copy of
> samples/livepatch/livepatch-annotated-sample.c:
>
> - modules.livepatch is generated in external dir
> - klp-convert is invoked for the livepatch module
> - the external livepatch module successfully loads
>
> But that was only testing external livepatch modules.
>
> I don't know if we need/want to support general external modules supplementing
> Symbols.list, at least for the initial klp-convert commit. I suppose external
> livepatch modules would then need to specify additional Symbols.list(s) files
> somehow as well.
I think we discussed it briefly and decided to postpone it for later
improvements. External modules are not so important in my opinion.
> >
> > BTW, 'Symbols.list' sounds like a file to list out symbols
> > for generic purposes, but in fact, the
> > file format is very specific for the klp-convert tool.
> > Perhaps, is it better to rename it so it infers
> > this is for livepatching? What do you think?
> >
>
> I don't know if the "Symbols.list" name and leading uppercase was based on any
> convention, but something like symbols.klp would be fine with me.
symbols.klp looks ok
Miroslav
next prev parent reply other threads:[~2019-08-20 7:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190509143859.9050-1-joe.lawrence@redhat.com>
[not found] ` <alpine.LSU.2.21.1906131451560.22698@pobox.suse.cz>
[not found] ` <b1a627a4-3702-9689-6c03-0c2123c06a2d@redhat.com>
[not found] ` <c9021573-11c6-b576-0aa6-97754c98a06e@redhat.com>
[not found] ` <20190614083435.uq3mk6mprbatysol@pathway.suse.cz>
2019-06-25 11:36 ` [PATCH v4 00/10] klp-convert livepatch build tooling Miroslav Benes
2019-06-25 13:24 ` Joe Lawrence
2019-06-25 19:08 ` Joe Lawrence
2019-06-26 10:27 ` Miroslav Benes
[not found] ` <20190509143859.9050-4-joe.lawrence@redhat.com>
2019-07-31 2:50 ` [PATCH v4 03/10] livepatch: Add klp-convert tool Masahiro Yamada
2019-07-31 3:36 ` Masahiro Yamada
2019-08-09 18:42 ` Joe Lawrence
2019-08-13 1:15 ` Masahiro Yamada
[not found] ` <20190509143859.9050-7-joe.lawrence@redhat.com>
2019-07-31 5:58 ` [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules Masahiro Yamada
2019-08-12 15:56 ` Joe Lawrence
2019-08-15 15:05 ` Masahiro Yamada
2019-08-16 8:19 ` Miroslav Benes
2019-08-16 12:43 ` Joe Lawrence
2019-08-16 19:01 ` Joe Lawrence
2019-08-19 3:50 ` Masahiro Yamada
2019-08-19 15:55 ` Joe Lawrence
2019-08-20 7:54 ` Miroslav Benes [this message]
2019-08-19 3:49 ` Masahiro Yamada
2019-08-19 7:31 ` Miroslav Benes
2019-08-19 16:02 ` Joe Lawrence
2019-08-22 3:35 ` Masahiro Yamada
2019-08-13 10:26 ` Miroslav Benes
[not found] ` <20190509143859.9050-8-joe.lawrence@redhat.com>
2019-08-16 11:35 ` [PATCH v4 07/10] livepatch: Add sample livepatch module Masahiro Yamada
2019-08-16 12:47 ` Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.1908200948260.9536@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=joe.lawrence@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).