live-patching.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miroslav Benes <mbenes@suse.cz>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Joe Lawrence <joe.lawrence@redhat.com>,
	mingo@redhat.com, jpoimboe@redhat.com, jikos@kernel.org,
	pmladek@suse.com, linux-kernel@vger.kernel.org,
	live-patching@vger.kernel.org
Subject: Re: [PATCH 0/3] ftrace: Introduce PERMANENT ftrace_ops flag
Date: Wed, 9 Oct 2019 12:33:33 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LSU.2.21.1910091231560.20879@pobox.suse.cz> (raw)
In-Reply-To: <20191008155022.61db3108@gandalf.local.home>

On Tue, 8 Oct 2019, Steven Rostedt wrote:

> On Tue, 8 Oct 2019 15:35:34 -0400
> Joe Lawrence <joe.lawrence@redhat.com> wrote:
> 
> > 
> > I wonder if the opposite would be more intuitive: when ftrace_enabled is
> > not set, don't allow livepatches to register ftrace filters and
> > likewise, don't allow ftrace_enabled to be unset if any livepatches are
> > already registered.  I guess you could make an argument either way, but
> > just offering another option.  Perhaps livepatches should follow similar
> > behavior of other ftrace clients (like perf probes?)
> 
> I believe I suggested the "PERMANENT" flag, but disabling ftrace_enable
> may be another approach. Might be much easier to maintain.

You did.
 
> > 
> > As for the approach in this patchset, is it consistent that livepatches
> > loaded after setting ftrace_enabled to 0 will successfully load, but not
> > execute their new code...  but then when ftrace_enabled is toggled, the
> > new livepatch code remains on?

No, it is not consistent and was not intended.

> > For example:
> > 
> > 1 - Turn ftrace_enabled off and load the /proc/cmdline livepatch test
> >     case, note that it reports a success patching transition, but
> >     doesn't run new its code:
> > 
> >   % dmesg -C
> >   % sysctl kernel.ftrace_enabled=0
> >   kernel.ftrace_enabled = 0
> >   % insmod lib/livepatch/test_klp_livepatch.ko 
> >   % echo $?
> >   0
> >   % dmesg
> >   [  450.579980] livepatch: enabling patch 'test_klp_livepatch'
> >   [  450.581243] livepatch: 'test_klp_livepatch': starting patching transition
> >   [  451.942971] livepatch: 'test_klp_livepatch': patching complete
> >   % cat /proc/cmdline 
> >   BOOT_IMAGE=(hd0,msdos1)/boot/vmlinuz-5.4.0-rc2+ root=UUID=c42bb089-b5c1-4e17-82bd-132f55bee54c ro console=ttyS0 console=ttyS0,115200n8 no_timer_check net.ifnames=0 crashkernel=auto
> > 
> > 2 - Turn ftrace_enabled on and see that the livepatch now works:
> > 
> >   % sysctl kernel.ftrace_enabled=1
> >   kernel.ftrace_enabled = 1
> >   % cat /proc/cmdline 
> >   test_klp_livepatch: this has been live patched
> > 
> > 3 - Turn ftrace_enabled off and see that it's still enabled:
> > 
> >   % sysctl kernel.ftrace_enabled=0
> >   kernel.ftrace_enabled = 0
> >   % cat /proc/cmdline 
> >   test_klp_livepatch: this has been live patched
> > 
> > Steps 2 and 3 match the behavior described by the patchset, but I was
> > particularly wondering what you thought about step 1.
> > 
> > IMHO, I would expect step 1 to fully enable the livepatch, or at the
> > very least, not report a patch transition (though that may confuse
> > userspace tools waiting for that report).

Yes.
 
> 
> I think I like your idea better. To prevent ftrace_enable from being
> disabled if a "permanent" option is set. Then we only need to have a
> permanent flag for the ftrace_ops, that will disable the ftrace_enable
> from being cleared. We can also prevent the ftrace_ops from being
> loaded if ftrace_enable is not set and the ftrace_ops has the PERMANENT
> flag set.

Agreed. Joe's approach is better. Let me prepare v2.

Thanks
Miroslav

  reply	other threads:[~2019-10-09 10:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07  8:17 [PATCH 0/3] ftrace: Introduce PERMANENT ftrace_ops flag Miroslav Benes
2019-10-07  8:17 ` [PATCH 1/3] ftrace: Make test_rec_ops_needs_regs() generic Miroslav Benes
2019-10-07  8:17 ` [PATCH 2/3] ftrace: Introduce PERMANENT ftrace_ops flag Miroslav Benes
2019-10-07  8:17 ` [PATCH 3/3] livepatch: Use FTRACE_OPS_FL_PERMANENT Miroslav Benes
2019-10-08 19:35 ` [PATCH 0/3] ftrace: Introduce PERMANENT ftrace_ops flag Joe Lawrence
2019-10-08 19:50   ` Steven Rostedt
2019-10-09 10:33     ` Miroslav Benes [this message]
2019-10-09 11:22   ` Petr Mladek
2019-10-09 14:23     ` Joe Lawrence
2019-10-09 14:26     ` Steven Rostedt
2019-10-10  8:50       ` Petr Mladek
2019-10-10 13:14         ` Steven Rostedt
2019-10-10 13:38           ` Miroslav Benes
2019-10-10 13:43             ` Steven Rostedt
2019-10-10 13:44               ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.21.1910091231560.20879@pobox.suse.cz \
    --to=mbenes@suse.cz \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).