From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA599C10F14 for ; Thu, 10 Oct 2019 13:38:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9478208C3 for ; Thu, 10 Oct 2019 13:38:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387542AbfJJNit (ORCPT ); Thu, 10 Oct 2019 09:38:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:55212 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728393AbfJJNit (ORCPT ); Thu, 10 Oct 2019 09:38:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B178DAEB3; Thu, 10 Oct 2019 13:38:47 +0000 (UTC) Date: Thu, 10 Oct 2019 15:38:20 +0200 (CEST) From: Miroslav Benes To: Steven Rostedt cc: Petr Mladek , jikos@kernel.org, Joe Lawrence , jpoimboe@redhat.com, mingo@redhat.com, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH 0/3] ftrace: Introduce PERMANENT ftrace_ops flag In-Reply-To: <20191010091403.5ecf0fdb@gandalf.local.home> Message-ID: References: <20191007081714.20259-1-mbenes@suse.cz> <20191008193534.GA16675@redhat.com> <20191009112234.bi7lvp4pvmna26vz@pathway.suse.cz> <20191009102654.501ad7c3@gandalf.local.home> <20191010085035.emsdks6xecazqc6k@pathway.suse.cz> <20191010091403.5ecf0fdb@gandalf.local.home> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: live-patching-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On Thu, 10 Oct 2019, Steven Rostedt wrote: > On Thu, 10 Oct 2019 10:50:35 +0200 > Petr Mladek wrote: > > > It will make the flag unusable for other ftrace users. But it > > will be already be the case when it can't be disabled. > > Honestly, I hate that flag. Most people don't even know about it. It > was added in the beginning of ftrace as a way to stop function tracing > in the latency tracer. But that use case has been obsoleted by > 328df4759c03e ("tracing: Add function-trace option to disable function > tracing of latency tracers"). I may just remove the damn thing and only > add it back if somebody complains about it. That would of course solve the issue too and code removal is always better. Miroslav