From: Miroslav Benes <mbenes@suse.cz>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: gor@linux.ibm.com, borntraeger@de.ibm.com, jpoimboe@redhat.com,
joe.lawrence@redhat.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, jikos@kernel.org, pmladek@suse.com,
nstange@suse.de, live-patching@vger.kernel.org
Subject: Re: [PATCH v2 3/3] s390/livepatch: Implement reliable stack tracing for the consistency model
Date: Wed, 30 Oct 2019 11:05:45 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.21.1910301104230.18400@pobox.suse.cz> (raw)
In-Reply-To: <20191029161751.GH5646@osiris>
On Tue, 29 Oct 2019, Heiko Carstens wrote:
> Hi Miroslav,
>
> > +bool unwind_next_frame_reliable(struct unwind_state *state)
> > +{
> ...
> > +}
> > +
> > void __unwind_start(struct unwind_state *state, struct task_struct *task,
> > struct pt_regs *regs, unsigned long sp,
> > bool unwind_reliable)
>
> Did you send the wrong version of your patch series? This patch does
> not integrate your new function into the existing one. Also the new
> parameter you added with the second patch isn't used at all.
No, the version should be correct. Only __unwind_start_reliable() was
integrated. The new parameter is used in arch_stack_walk_reliable()
(unwind_reliable is set to true) and it is propagated to get_stack_info()
where it is used to simplify things for the case.
Miroslav
next prev parent reply other threads:[~2019-10-30 10:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 14:39 [PATCH v2 0/3] s390/livepatch: Implement reliable stack tracing for the consistency model Miroslav Benes
2019-10-29 14:39 ` [PATCH v2 1/3] s390/unwind: drop unnecessary code around calling ftrace_graph_ret_addr() Miroslav Benes
2019-10-29 14:39 ` [PATCH v2 2/3] s390/unwind: prepare the unwinding interface for reliable stack traces Miroslav Benes
2019-10-29 14:39 ` [PATCH v2 3/3] s390/livepatch: Implement reliable stack tracing for the consistency model Miroslav Benes
2019-10-29 16:17 ` Heiko Carstens
2019-10-30 10:05 ` Miroslav Benes [this message]
2019-10-29 16:34 ` [PATCH v2 0/3] " Heiko Carstens
2019-10-30 10:12 ` Miroslav Benes
2019-10-31 15:24 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.1910301104230.18400@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=nstange@suse.de \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).