From: Miroslav Benes <mbenes@suse.cz>
To: Petr Mladek <pmladek@suse.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
Nicolai Stange <nstange@suse.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] livepatch/samples/selftest: Clean up show variables handling
Date: Fri, 17 Jan 2020 09:26:17 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.21.2001170926040.29867@pobox.suse.cz> (raw)
In-Reply-To: <20200116153145.2392-1-pmladek@suse.com>
On Thu, 16 Jan 2020, Petr Mladek wrote:
> Dan Carpenter reported suspicious allocations of shadow variables
> in the sample module, see
> https://lkml.kernel.org/r/20200107132929.ficffmrm5ntpzcqa@kili.mountain
>
> The code did not cause a real problem. But it was indeed misleading
> and semantically wrong. I got confused several times when cleaning it.
> So I decided to split the change into few steps. I hope that
> it will help reviewers and future readers.
>
> The changes of the sample module are basically the same as in the RFC.
> In addition, there is a clean up of the module used by the selftest.
>
>
> Petr Mladek (4):
> livepatch/sample: Use the right type for the leaking data pointer
> livepatch/selftest: Clean up shadow variable names and type
> livepatch/samples/selftest: Use klp_shadow_alloc() API correctly
> livepatch: Handle allocation failure in the sample of shadow variable
> API
>
> lib/livepatch/test_klp_shadow_vars.c | 119 +++++++++++++++++-------------
> samples/livepatch/livepatch-shadow-fix1.c | 39 ++++++----
> samples/livepatch/livepatch-shadow-fix2.c | 4 +-
> samples/livepatch/livepatch-shadow-mod.c | 4 +-
> 4 files changed, 99 insertions(+), 67 deletions(-)
Acked-by: Miroslav Benes <mbenes@suse.cz>
M
next prev parent reply other threads:[~2020-01-17 8:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 15:31 [PATCH 0/4] livepatch/samples/selftest: Clean up show variables handling Petr Mladek
2020-01-16 15:31 ` [PATCH 1/4] livepatch/sample: Use the right type for the leaking data pointer Petr Mladek
2020-01-16 15:31 ` [PATCH 2/4] livepatch/selftest: Clean up shadow variable names and type Petr Mladek
2020-01-16 15:31 ` [PATCH 3/4] livepatch/samples/selftest: Use klp_shadow_alloc() API correctly Petr Mladek
2020-01-16 15:31 ` [PATCH 4/4] livepatch: Handle allocation failure in the sample of shadow variable API Petr Mladek
2020-01-16 19:29 ` [PATCH 0/4] livepatch/samples/selftest: Clean up show variables handling Joe Lawrence
2020-01-17 8:26 ` Miroslav Benes [this message]
2020-01-17 9:41 ` Kamalesh Babulal
2020-01-17 10:13 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2001170926040.29867@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=dan.carpenter@oracle.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=nstange@suse.de \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).