From: Miroslav Benes <mbenes@suse.cz>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, jpoimboe@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
xen-devel@lists.xenproject.org, jslaby@suse.cz
Subject: Re: [Xen-devel] [PATCH 1/2] x86/xen: Make the boot CPU idle task reliable
Date: Thu, 12 Mar 2020 16:17:04 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.21.2003121616190.28317@pobox.suse.cz> (raw)
In-Reply-To: <dc55b23b-c0d2-3be0-222f-d104548c8cf4@citrix.com>
[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]
On Thu, 12 Mar 2020, Andrew Cooper wrote:
> On 12/03/2020 14:20, Miroslav Benes wrote:
> > The unwinder reports the boot CPU idle task's stack on XEN PV as
> > unreliable, which affects at least live patching. There are two reasons
> > for this. First, the task does not follow the x86 convention that its
> > stack starts at the offset right below saved pt_regs. It allows the
> > unwinder to easily detect the end of the stack and verify it. Second,
> > startup_xen() function does not store the return address before jumping
> > to xen_start_kernel() which confuses the unwinder.
> >
> > Amend both issues by moving the starting point of initial stack in
> > startup_xen() and storing the return address before the jump.
> >
> > Signed-off-by: Miroslav Benes <mbenes@suse.cz>
> > ---
> > arch/x86/xen/xen-head.S | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
> > index 1d0cee3163e4..642f346bfe02 100644
> > --- a/arch/x86/xen/xen-head.S
> > +++ b/arch/x86/xen/xen-head.S
> > @@ -35,7 +35,7 @@ SYM_CODE_START(startup_xen)
> > rep __ASM_SIZE(stos)
> >
> > mov %_ASM_SI, xen_start_info
> > - mov $init_thread_union+THREAD_SIZE, %_ASM_SP
> > + mov $init_thread_union+THREAD_SIZE-SIZEOF_PTREGS, %_ASM_SP
> >
> > #ifdef CONFIG_X86_64
> > /* Set up %gs.
> > @@ -51,7 +51,9 @@ SYM_CODE_START(startup_xen)
> > wrmsr
> > #endif
> >
> > + push $1f
> > jmp xen_start_kernel
> > +1:
>
> Hang on. Isn't this just a `call` instruction written in longhand?
It is (as far as I know). I wanted to keep it opencoded for a reason I
don't remember now. I'll change it. Thanks.
Miroslav
next prev parent reply other threads:[~2020-03-12 15:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 14:20 [PATCH 0/2] x86/xen: Make idle tasks reliable Miroslav Benes
2020-03-12 14:20 ` [PATCH 1/2] x86/xen: Make the boot CPU idle task reliable Miroslav Benes
2020-03-12 15:04 ` [Xen-devel] " Andrew Cooper
2020-03-12 15:17 ` Miroslav Benes [this message]
2020-03-16 14:33 ` Boris Ostrovsky
2020-03-17 9:13 ` Miroslav Benes
2020-03-12 14:20 ` [RFC PATCH 2/2] x86/xen: Make the secondary CPU idle tasks reliable Miroslav Benes
2020-03-13 8:26 ` Jürgen Groß
2020-03-13 9:54 ` Miroslav Benes
2020-03-16 15:51 ` Miroslav Benes
2020-03-16 20:35 ` Josh Poimboeuf
2020-03-17 9:16 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2003121616190.28317@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).