From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98BC0C433E0 for ; Mon, 1 Jun 2020 11:48:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8417D2074B for ; Mon, 1 Jun 2020 11:48:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725977AbgFALsX (ORCPT ); Mon, 1 Jun 2020 07:48:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:33104 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbgFALsX (ORCPT ); Mon, 1 Jun 2020 07:48:23 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7EFFEAD5F; Mon, 1 Jun 2020 11:48:23 +0000 (UTC) Date: Mon, 1 Jun 2020 13:48:21 +0200 (CEST) From: Miroslav Benes To: Yannick Cote cc: live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, joe.lawrence@redhat.com Subject: Re: [PATCH 0/4] selftests/livepatch: rework of test-klp-{callbacks,shadow_vars} In-Reply-To: <20200528134849.7890-1-ycote@redhat.com> Message-ID: References: <20200528134849.7890-1-ycote@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="1678380546-1074926875-1591012101=:2043" Sender: live-patching-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1678380546-1074926875-1591012101=:2043 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 28 May 2020, Yannick Cote wrote: > The test-klp-callbacks change implement a synchronization replacement of > initial code to use completion variables instead of delays. The > completion variable interlocks the busy module with the concurrent > loading of the target livepatch patches which works with the execution > flow instead of estimated time delays. > > The test-klp-shadow-vars changes first refactors the code to be more of > a readable example as well as continuing to verify the component code. > The patch is broken in two to display the renaming and restructuring in > part 1 and the addition and change of logicĀ in part 2. The last change > frees memory before bailing in case of errors. With the small comments, I made, fixed Acked-by: Miroslav Benes M --1678380546-1074926875-1591012101=:2043--