Re: [PATCH 1/3] selftests/livepatch: Don't clear dmesg when running tests

[Miroslav Benes <mbenes@suse.cz>]

On Thu, 11 Jun 2020, Joe Lawrence wrote:

> On 6/11/20 3:38 AM, Miroslav Benes wrote:
> > Hi,
> > 
> > On Wed, 10 Jun 2020, Joe Lawrence wrote:
> > 
> >> diff --git a/tools/testing/selftests/livepatch/test-callbacks.sh
> >> b/tools/testing/selftests/livepatch/test-callbacks.sh
> >> index 32b57ba07f4f..c3d949da5bb7 100755
> >> --- a/tools/testing/selftests/livepatch/test-callbacks.sh
> >> +++ b/tools/testing/selftests/livepatch/test-callbacks.sh
> >> @@ -12,7 +12,7 @@ MOD_TARGET_BUSY=test_klp_callbacks_busy
> >>   setup_config
> >>   
> >>   
> >> -# TEST: target module before livepatch
> >> +start_test "target module before livepatch"
> >>   #
> >>   # Test a combination of loading a kernel module and a livepatch that
> >>   # patches a function in the first module.  Load the target module
> >> @@ -28,9 +28,6 @@ setup_config
> >>   #   unpatching transition starts.  klp_objects are reverted, post-patch
> >>   #   callbacks execute and the transition completes.
> >>   
> >> -echo -n "TEST: target module before livepatch ... "
> >> -dmesg -C
> >> -
> > 
> > A nit, but I think it would be better to place start_test here below the
> > comment. The same for other occurrences in test-callbacks.sh.
> > 
> 
> The idea was to remove the duplicate # TEST: comment and then the same echo -n
> "TEST: ..." entries.
> 
> Would it still look okay if we move start_test to below the comment and omit
> that # TEST ... part?  (This might be what you're suggesting, but I wanted to
> make sure.)

Yes, that is what I meant. I am sorry because it was not clear.

Thanks
Miroslav