From: Miroslav Benes <mbenes@suse.cz>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"cl@linux.com" <cl@linux.com>,
"pmladek@suse.com" <pmladek@suse.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"jeyu@kernel.org" <jeyu@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
"live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
"atomlin@atomlin.com" <atomlin@atomlin.com>,
"ghalat@redhat.com" <ghalat@redhat.com>,
"allen.lkml@gmail.com" <allen.lkml@gmail.com>,
"void@manifault.com" <void@manifault.com>,
"joe@perches.com" <joe@perches.com>,
"msuchanek@suse.de" <msuchanek@suse.de>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>
Subject: Re: [PATCH v5 13/13] module: Move version support into a separate file
Date: Thu, 17 Feb 2022 16:51:04 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.21.2202171648590.29121@pobox.suse.cz> (raw)
In-Reply-To: <CANfR36gVY+1k7YJy0fn1z+mGv-LqEmZJSvSHXn_BFR4WC+oJrQ@mail.gmail.com>
> > > +struct symsearch {
> > > + const struct kernel_symbol *start, *stop;
> > > + const s32 *crcs;
> > > + enum mod_license {
> > > + NOT_GPL_ONLY,
> > > + GPL_ONLY,
> > > + } license;
> > > +};
> >
> > Why don't leave this in main.c ?
>
> Yes, struct 'symsearch' is not used outside of kernel/module/main.c.
It is not, but "struct find_symbol_arg", which you moved, uses "enum
mod_license" defined above, so you can either leave it as it is, or carve
"enum mod_license" definition out.
Miroslav
next prev parent reply other threads:[~2022-02-17 15:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 17:11 [PATCH v5 11/13] module: Move sysfs support into a separate file Aaron Tomlin
2022-02-09 17:11 ` [PATCH v5 12/13] module: Move kdb_modules list out of core code Aaron Tomlin
2022-02-10 14:05 ` Christophe Leroy
2022-02-13 14:14 ` Aaron Tomlin
2022-02-09 17:11 ` [PATCH v5 13/13] module: Move version support into a separate file Aaron Tomlin
2022-02-10 14:28 ` Christophe Leroy
2022-02-13 18:03 ` Aaron Tomlin
2022-02-13 18:29 ` Christophe Leroy
2022-02-15 15:05 ` Aaron Tomlin
2022-02-15 15:11 ` Christophe Leroy
2022-02-17 15:51 ` Miroslav Benes [this message]
2022-02-17 16:26 ` Aaron Tomlin
2022-02-10 14:00 ` [PATCH v5 11/13] module: Move sysfs " Christophe Leroy
2022-02-13 13:32 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2202171648590.29121@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=allen.lkml@gmail.com \
--cc=atomlin@atomlin.com \
--cc=atomlin@redhat.com \
--cc=christophe.leroy@csgroup.eu \
--cc=cl@linux.com \
--cc=ghalat@redhat.com \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=msuchanek@suse.de \
--cc=oleksandr@natalenko.name \
--cc=pmladek@suse.com \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).