live-patching.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miroslav Benes <mbenes@suse.cz>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] livepatch: Add compiler optimization disclaimer/docs
Date: Fri, 31 May 2024 13:23:18 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LSU.2.21.2405311319090.8344@pobox.suse.cz> (raw)
In-Reply-To: <20200721161407.26806-1-joe.lawrence@redhat.com>

Hi,

On Tue, 21 Jul 2020, Joe Lawrence wrote:

> In light of [PATCH] Revert "kbuild: use -flive-patching when
> CONFIG_LIVEPATCH is enabled" [1], we should add some loud disclaimers
> and explanation of the impact compiler optimizations have on
> livepatching.
> 
> The first commit provides detailed explanations and examples.  The list
> was taken mostly from Miroslav's LPC talk a few years back.  This is a
> bit rough, so corrections and additional suggestions welcome.  Expanding
> upon the source-based patching approach would be helpful, too.
> 
> The second commit adds a small README.rst file in the livepatch samples
> directory pointing the reader to the doc introduced in the first commit.
> 
> I didn't touch the livepatch kselftests yet as I'm still unsure about
> how to best account for IPA here.  We could add the same README.rst
> disclaimer here, too, but perhaps we have a chance to do something more.
> Possibilities range from checking for renamed functions as part of their
> build, or the selftest scripts, or even adding something to the kernel
> API.  I think we'll have a better idea after reviewing the compiler
> considerations doc.

thanks to Marcos for resurrecting this.

Joe, do you have an updated version by any chance? Some things have 
changed since July 2020 so it calls for a new review. If there was an 
improved version, it would be easier. If not, no problem at all.

Miroslav

  parent reply	other threads:[~2024-05-31 11:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 16:14 [PATCH 0/2] livepatch: Add compiler optimization disclaimer/docs Joe Lawrence
2020-07-21 16:14 ` [PATCH 1/2] docs/livepatch: Add new compiler considerations doc Joe Lawrence
2020-07-21 23:04   ` Josh Poimboeuf
2020-07-22 17:03     ` Joe Lawrence
2020-07-22 20:51       ` Josh Poimboeuf
2020-08-06 12:03         ` Petr Mladek
2020-08-10 19:46           ` refactoring livepatch documentation was " Joe Lawrence
2020-09-01 17:12             ` Josh Poimboeuf
2020-09-02 14:00             ` Miroslav Benes
2020-09-02 13:45   ` Miroslav Benes
2024-05-29 14:12     ` Marcos Paulo de Souza
2020-07-21 16:14 ` [PATCH 2/2] samples/livepatch: Add README.rst disclaimer Joe Lawrence
2020-08-06 12:07   ` Petr Mladek
2020-09-02 13:46   ` Miroslav Benes
2024-05-29 13:51   ` Marcos Paulo de Souza
2024-05-31 11:23 ` Miroslav Benes [this message]
2024-05-31 19:57   ` [PATCH 0/2] livepatch: Add compiler optimization disclaimer/docs Joe Lawrence
2024-06-07  8:01     ` Miroslav Benes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.21.2405311319090.8344@pobox.suse.cz \
    --to=mbenes@suse.cz \
    --cc=joe.lawrence@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).