Live-Patching Archive on
 help / color / Atom feed
From: Joe Lawrence <>
To: Miroslav Benes <>
Subject: Re: [PATCH] selftests/livepatch: filter 'taints' from dmesg comparison
Date: Thu, 7 Nov 2019 09:40:03 -0500
Message-ID: <> (raw)
In-Reply-To: <>

On 11/7/19 3:42 AM, Miroslav Benes wrote:
> On Wed, 6 Nov 2019, Joe Lawrence wrote:
>> The livepatch selftests compare expected dmesg output to verify kernel
>> behavior.  They currently filter out "tainting kernel with
>> TAINT_LIVEPATCH" messages which may be logged when loading livepatch
>> modules.
>> Further filter the log to also drop "loading out-of-tree module taints
>> kernel" messages in case the klp_test modules have been build without
>> the in-tree module flag.
> That is true, but "tainting kernel with TAINT_LIVEPATCH" should be printed
> out even in this case. check_modinfo_livepatch() is called for all modules
> and relies on MODINFO(livepatch, Y).
>  > So either the bug is elsewhere or I need one more cup of tea.

I'm only half a cup in this morning myself, but...

In my scenario, I saw in the kernel log:

   % modprobe test_klp_livepatch
   test_klp_livepatch: loading out-of-tree module taints kernel.
   test_klp_livepatch: module verification failed: signature and/or 
required key missing - tainting kernel

and because check_result() only removes 'tainting' with grep -v, the 
expected log message failed to match with the actual filtered message 
because of the first 'taints' message.

So this change just adds more to the filtered out strings:

   result = dmesg | grep -v <filtered out strings> | grep <interesting 

BTW, none of the callers of check_result() bother to include either 
taint message since I think they are only ever emitted on the first 

-- Joe

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 22:28 Joe Lawrence
2019-11-07  8:42 ` Miroslav Benes
2019-11-07 14:40   ` Joe Lawrence [this message]
2019-11-07 14:53     ` Miroslav Benes
2019-11-07 15:13       ` Joe Lawrence
2019-11-07 15:24         ` Miroslav Benes
2019-11-07 15:33           ` Joe Lawrence
2019-11-07 12:22 ` Kamalesh Babulal
2019-11-07 15:29 ` Petr Mladek

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Live-Patching Archive on

Archives are clonable:
	git clone --mirror live-patching/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 live-patching live-patching/ \
	public-inbox-index live-patching

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone