archive mirror
 help / color / mirror / Atom feed
From: Kamalesh Babulal <>
To: Joe Lawrence <>,
Cc:, Petr Mladek <>,
	Naresh Kamboju <>
Subject: Re: [PATCH] selftests/livepatch: Use "comm" instead of "diff" for dmesg
Date: Mon, 13 Jul 2020 17:27:16 +0530	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 11/07/20 12:07 am, Joe Lawrence wrote:
> BusyBox diff doesn't support the GNU diff '--LTYPE-line-format' options
> that were used in the selftests to filter older kernel log messages from
> dmesg output.
> Use "comm" which is more available in smaller boot environments.
> Reported-by: Naresh Kamboju <>
> Signed-off-by: Joe Lawrence <>

LGTM. All the test passes on non-busybox environment.

Reviewed-by: Kamalesh Babulal <>


  reply	other threads:[~2020-07-13 11:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-10 18:37 [PATCH] selftests/livepatch: Use "comm" instead of "diff" for dmesg Joe Lawrence
2020-07-13 11:57 ` Kamalesh Babulal [this message]
2020-07-13 12:51 ` Yannick Cote
2020-07-14  7:53 ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).