live-patching.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Lawrence <joe.lawrence@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
	shuah@kernel.org
Subject: Re: [PATCH] selftests/livepatch: filter 'taints' from dmesg comparison
Date: Thu, 7 Nov 2019 10:33:43 -0500	[thread overview]
Message-ID: <d7518cc0-2166-a5cc-9d3f-f70bbbfc3725@redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.21.1911071619380.21726@pobox.suse.cz>

On 11/7/19 10:24 AM, Miroslav Benes wrote:
>> In my test, I had a kernel tree, but only wanted to build the test modules.
>> Once I did a 'make modules SUBDIR=' or 'make M= ...' KBUILD_EXTMOD got flipped
>> on and the modules lost in-tree status.  No amount of googling could tell me
>> how to build a single in-tree directory of modules :(
> 
> "make lib/livepatch/test_klp_livepatch.ko" should do the trick. "make
> lib/livepatch/" only builds the object files and I haven't found a way to
> make it link .ko modules other than specifying them one by one directly.
> 

Forgot to mention that this works too, but I was looking to script it 
and not have each .ko hardcoded in a series of make commands.  Anyway, 
it's a strange use-case and it was something I was only cooking up for 
an in-house continuous testing scenario.

>> And then it seemed that
>> opening the tests for OOT modules was reasonable anyway.
> 
> That's an interesting idea. If a module is in tree, it is under our
> control. So we know what "testing capabilities" it offers. I guess that
> with OOT testing modules the selftests would have to be smarter.
> 

It would probably go hand in hand with custom test scripts that would 
understand the OOT module capabilities, I think.  I doubt anyone will 
try it (besides me), but the grep filter was there and it was an easy tweak.

-- Joe


  reply	other threads:[~2019-11-07 15:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 22:28 [PATCH] selftests/livepatch: filter 'taints' from dmesg comparison Joe Lawrence
2019-11-07  8:42 ` Miroslav Benes
2019-11-07 14:40   ` Joe Lawrence
2019-11-07 14:53     ` Miroslav Benes
2019-11-07 15:13       ` Joe Lawrence
2019-11-07 15:24         ` Miroslav Benes
2019-11-07 15:33           ` Joe Lawrence [this message]
2019-11-07 12:22 ` Kamalesh Babulal
2019-11-07 15:29 ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7518cc0-2166-a5cc-9d3f-f70bbbfc3725@redhat.com \
    --to=joe.lawrence@redhat.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).