Live-Patching Archive on lore.kernel.org
 help / color / Atom feed
From: shuah <shuah@kernel.org>
To: Joe Lawrence <joe.lawrence@redhat.com>,
	live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: Jiri Benc <jbenc@redhat.com>, shuah <shuah@kernel.org>
Subject: Re: [PATCH v3] selftests/livepatch: add test skip handling
Date: Tue, 23 Jul 2019 09:53:53 -0600
Message-ID: <e450e2ec-b683-f712-c8d5-ef1c2e2dee7c@kernel.org> (raw)
In-Reply-To: <20190722140544.29867-1-joe.lawrence@redhat.com>

Hi Joe,

On 7/22/19 8:05 AM, Joe Lawrence wrote:
> Add a skip() message function that stops the test, logs an explanation,
> and sets the "skip" return code (4).
> 
> Before loading a livepatch self-test kernel module, first verify that
> we've built and installed it by running a 'modprobe --dry-run'.  This
> should catch a few environment issues, including !CONFIG_LIVEPATCH and
> !CONFIG_TEST_LIVEPATCH.  In these cases, exit gracefully with the new
> skip() function.
> 
> Reported-by: Jiri Benc <jbenc@redhat.com>
> Suggested-by: Shuah Khan <shuah@kernel.org>
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> ---
> 
> v3: tweak modprobe error message: check kernel config and run as root,
> so output now looks like [shuah] :
> 

Couple of small tweaks to user visible message below.

>    % make run_tests
>    TAP version 13
>    1..3
>    # selftests: livepatch: test-livepatch.sh
>    # TEST: basic function patching ... SKIP: unable load module test_klp_livepatch, verify CONFIG_TEST_LIVEPATCH=m and run self-tests as root
>    not ok 1 selftests: livepatch: test-livepatch.sh # SKIP

unable to

>    # selftests: livepatch: test-callbacks.sh
>    # TEST: target module before livepatch ... SKIP: unable load module test_klp_callbacks_mod, verify CONFIG_TEST_LIVEPATCH=m and run self-tests as root

unable to

>    not ok 2 selftests: livepatch: test-callbacks.sh # SKIP
>    # selftests: livepatch: test-shadow-vars.sh
>    # TEST: basic shadow variable API ... SKIP: unable load module test_klp_shadow_vars, verify CONFIG_TEST_LIVEPATCH=m and run self-tests as root
> 

unable to

thanks for taking care of this.

-- Shuah

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 14:05 Joe Lawrence
2019-07-23 15:53 ` shuah [this message]
2019-07-24 20:05   ` [PATCH v4] " Joe Lawrence
2019-07-24 20:19     ` shuah
2019-07-24  6:27 ` [PATCH v3] " Petr Mladek
2019-07-24 16:45   ` shuah
2019-07-24 18:45     ` Joe Lawrence
2019-07-24 19:51       ` shuah

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e450e2ec-b683-f712-c8d5-ef1c2e2dee7c@kernel.org \
    --to=shuah@kernel.org \
    --cc=jbenc@redhat.com \
    --cc=joe.lawrence@redhat.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Live-Patching Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/live-patching/0 live-patching/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 live-patching live-patching/ https://lore.kernel.org/live-patching \
		live-patching@vger.kernel.org
	public-inbox-index live-patching

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.live-patching


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git