From: Jens Axboe <axboe@kernel.dk>
To: Miroslav Benes <mbenes@suse.cz>, Joe Lawrence <joe.lawrence@redhat.com>
Cc: Dong Kai <dongkai11@huawei.com>,
jpoimboe@redhat.com, jikos@kernel.org, pmladek@suse.com,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch: klp_send_signal should treat PF_IO_WORKER like PF_KTHREAD
Date: Thu, 25 Mar 2021 10:30:37 -0600 [thread overview]
Message-ID: <f4969563-23fa-cb49-8243-d600f1bf0b23@kernel.dk> (raw)
In-Reply-To: <alpine.LSU.2.21.2103251026180.30447@pobox.suse.cz>
On 3/25/21 3:30 AM, Miroslav Benes wrote:
>> (PF_KTHREAD | PF_IO_WORKER) is open coded in soo many places maybe this is a
>> silly question, but...
>>
>> If the livepatch code could use fake_signal_wake_up(), we could consolidate
>> the pattern in klp_send_signals() with the one in freeze_task(). Then there
>> would only one place for wake up / fake signal logic.
>>
>> I don't fully understand the differences in the freeze_task() version, so I
>> only pose this as a question and not v2 request.
>
> The plan was to remove our live patching fake signal completely and use
> the new infrastructure Jens proposed in the past.
That would be great, I've actually been waiting for that to show up!
I would greatly prefer this approach if you deem it suitable for 5.12,
if not we'll still need the temporary work-around for live patching.
--
Jens Axboe
next prev parent reply other threads:[~2021-03-25 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 1:48 [PATCH] livepatch: klp_send_signal should treat PF_IO_WORKER like PF_KTHREAD Dong Kai
2021-03-25 2:51 ` Joe Lawrence
2021-03-25 9:30 ` Miroslav Benes
2021-03-25 16:30 ` Jens Axboe [this message]
2021-03-26 8:39 ` Miroslav Benes
2021-03-25 9:26 ` Miroslav Benes
2021-03-25 16:43 ` Joe Lawrence
2021-03-26 6:31 ` dongkai (H)
2021-03-25 16:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4969563-23fa-cb49-8243-d600f1bf0b23@kernel.dk \
--to=axboe@kernel.dk \
--cc=dongkai11@huawei.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).