From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 177E2C2BB1B for ; Wed, 14 Oct 2020 09:24:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B048F20709 for ; Wed, 14 Oct 2020 09:24:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="cjD4hai8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729095AbgJNJYQ (ORCPT ); Wed, 14 Oct 2020 05:24:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388196AbgJNJU5 (ORCPT ); Wed, 14 Oct 2020 05:20:57 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37CE0C08EADD for ; Tue, 13 Oct 2020 16:37:52 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id r10so737705pgb.10 for ; Tue, 13 Oct 2020 16:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vNrLxhuzbKySTdaq3eK6IYs4qYFra1Niz95iXgK6Jj4=; b=cjD4hai8nvmN++DcR3kvZkEq/tP8L40YpzvCPlc1ePqdY1yVT4JeA3OyuLC4W3e1K6 6g+xwrF/3qc5tVO4LZ1OR/ICoupDOTDlTFkLsGQvmzNxkDIDGhFTkBUkcJaWzr3GRxMk lGIalkMtRUo+mFS6WFpI420AIzjcLspBbrklvjlYwnFmtxgj58/WvxgbpXvEFYcxRGfY sLxv+V3HQFLs4wTtJ/tursNEIZDI9JR+TlZstbItQSZ+IcKyAAixFOMDyrqVWd+re+wg 5FRLz2g5W+UUPxzw/1FNbGPqzsvuQbQP4wQdVIC1muE+0mzfQdDauwIowzItn3ATHWPk 1KYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vNrLxhuzbKySTdaq3eK6IYs4qYFra1Niz95iXgK6Jj4=; b=sC4d6UxF+03SSAzhyfu84VERvmXZwVRKg+QusQuWA/CxGJRo4g2FpMJnzhWFF6CYaj GDVai0tZFaL8xXaU2aQIzdU88WVH6ArKC82AfXHE4cxmiJ8aeI5Bzq94Ow+4ME5gdlKG /7R8xGtoBb+Pj0DXlWOaYKefBpR8pnDzToju2eDdWN9+GnTiW7UuCe8POSrtB5RbE4Lp xfw/VdFeX/dFOZso79VSHzyh0Vh3uQnnaS+Th4aVa2rx2t456Xh+JrzGLhm1mlHUYkwE EVUywYHDFNQvwpgpdA4VdUvZgWhLqOexJqOy+Z6kfC4qmM51HUz3Eaw5J2nyW1j+KKyW I8Cg== X-Gm-Message-State: AOAM531BB2PTUrbdvaYJmG6VNAW6YXCbMQDjeBbTjZRGjcsMxSbsb4ha 0/+ORiB5WTP5ti3tGzhfidq7PR5g8gB88uTB X-Google-Smtp-Source: ABdhPJylS9WM3J27JvugooESy3X8ZP2DkugADfW8R9kmS5rfhg9PZZ7pOQiiHHcwmhl2bDhMJ1JARQ== X-Received: by 2002:a65:4bcc:: with SMTP id p12mr1491715pgr.353.1602632271367; Tue, 13 Oct 2020 16:37:51 -0700 (PDT) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id u27sm810116pgm.60.2020.10.13.16.37.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Oct 2020 16:37:50 -0700 (PDT) Subject: Re: [PATCHSET RFC v3 0/6] Add support for TIF_NOTIFY_SIGNAL To: Thomas Gleixner , Miroslav Benes Cc: Oleg Nesterov , linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, peterz@infradead.org, live-patching@vger.kernel.org References: <20201005150438.6628-1-axboe@kernel.dk> <20201008145610.GK9995@redhat.com> <9a01ab10-3140-3fa6-0fcf-07d3179973f2@kernel.dk> <3c3616f2-8801-1d42-6d7d-3dfbf977edb2@kernel.dk> <87lfg9og3b.fsf@nanos.tec.linutronix.de> From: Jens Axboe Message-ID: Date: Tue, 13 Oct 2020 17:37:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87lfg9og3b.fsf@nanos.tec.linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On 10/13/20 5:34 PM, Thomas Gleixner wrote: > Jens, > > On Tue, Oct 13 2020 at 13:39, Jens Axboe wrote: >> On 10/12/20 11:27 AM, Miroslav Benes wrote: >> I'm continuing to hone the series, what's really missing so far is arch >> review. Most conversions are straight forward, some I need folks to >> definitely take a look at (arm, s390). powerpc is also a bit hair right >> now, but I'm told that 5.10 will kill a TIF flag there, so that'll make >> it trivial once I rebase on that. > > can you pretty please not add that to anything which is not going > through kernel/entry/ ? Certainly, tif-task_work is just a holding ground for all of it so far. Once the core bits are agreed upon and merged, then I'll bounce the rest through the arch maintainers. So please don't view it as on cohesive series, it only is up until (and including): commit 8dc14b576a9bf13dba4993e4ddb4068d39dee1e9 Author: Jens Axboe Date: Thu Oct 1 13:29:21 2020 -0600 task_work: use TIF_NOTIFY_SIGNAL if available > The amount of duplicated and differently buggy, inconsistent and > incomplete code in syscall and exception handling is just annoying. > > It's perfectly fine if we keep that #ifdeffery around for a while and > encourage arch folks to move over to the generic infrastructure instead > of proliferating the status quo by adding this to their existing pile. Agree > The #ifdef guarding this in set_notify_signal() and other core code > places wants to be: > > #if defined(CONFIG_GENERIC_ENTRY) && defined(TIF_NOTIFY_SIGNAL) OK no problem, I'll fix that up. -- Jens Axboe