Live-Patching Archive on
 help / color / Atom feed
From: "Jürgen Groß" <>
To: Miroslav Benes <>,,,,,,,
Subject: Re: [PATCH v3 1/2] x86/xen: Make the boot CPU idle task reliable
Date: Thu, 26 Mar 2020 10:29:40 +0100
Message-ID: <> (raw)
In-Reply-To: <>

On 26.03.20 10:26, Miroslav Benes wrote:
> The unwinder reports the boot CPU idle task's stack on XEN PV as
> unreliable, which affects at least live patching. There are two reasons
> for this. First, the task does not follow the x86 convention that its
> stack starts at the offset right below saved pt_regs. It allows the
> unwinder to easily detect the end of the stack and verify it. Second,
> startup_xen() function does not store the return address before jumping
> to xen_start_kernel() which confuses the unwinder.
> Amend both issues by moving the starting point of initial stack in
> startup_xen() and storing the return address before the jump, which is
> exactly what call instruction does.
> Signed-off-by: Miroslav Benes <>

Reviewed-by: Juergen Gross <>


  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26  9:26 [PATCH v3 0/2] x86/xen: Make idle tasks reliable Miroslav Benes
2020-03-26  9:26 ` [PATCH v3 1/2] x86/xen: Make the boot CPU idle task reliable Miroslav Benes
2020-03-26  9:29   ` Jürgen Groß [this message]
2020-03-26  9:26 ` [PATCH v3 2/2] x86/xen: Make the secondary CPU idle tasks reliable Miroslav Benes
2020-03-26  9:30   ` Jürgen Groß

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Live-Patching Archive on

Archives are clonable:
	git clone --mirror live-patching/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 live-patching live-patching/ \
	public-inbox-index live-patching

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone