Live-Patching Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] selftests/livepatch: Disable the timeout
@ 2019-10-25 11:50 Miroslav Benes
  2019-10-25 14:14 ` Joe Lawrence
  2019-10-25 18:00 ` Jiri Kosina
  0 siblings, 2 replies; 3+ messages in thread
From: Miroslav Benes @ 2019-10-25 11:50 UTC (permalink / raw)
  To: jpoimboe, jikos, pmladek, joe.lawrence, shuah
  Cc: linux-kernel, live-patching, linux-kselftest, Miroslav Benes

Commit 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second
timeout per test") introduced a timeout per test. Livepatch tests could
run longer than 45 seconds, especially on slower machines. They do not
hang and they detect if something goes awry with internal accounting.

Better than looking for an arbitrary value, just disable the timeout for
livepatch selftests.

Signed-off-by: Miroslav Benes <mbenes@suse.cz>
---
 tools/testing/selftests/livepatch/settings | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 tools/testing/selftests/livepatch/settings

diff --git a/tools/testing/selftests/livepatch/settings b/tools/testing/selftests/livepatch/settings
new file mode 100644
index 000000000000..e7b9417537fb
--- /dev/null
+++ b/tools/testing/selftests/livepatch/settings
@@ -0,0 +1 @@
+timeout=0
-- 
2.23.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] selftests/livepatch: Disable the timeout
  2019-10-25 11:50 [PATCH] selftests/livepatch: Disable the timeout Miroslav Benes
@ 2019-10-25 14:14 ` Joe Lawrence
  2019-10-25 18:00 ` Jiri Kosina
  1 sibling, 0 replies; 3+ messages in thread
From: Joe Lawrence @ 2019-10-25 14:14 UTC (permalink / raw)
  To: Miroslav Benes
  Cc: jpoimboe, jikos, pmladek, shuah, linux-kernel, live-patching,
	linux-kselftest

On Fri, Oct 25, 2019 at 01:50:41PM +0200, Miroslav Benes wrote:
> Commit 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second
> timeout per test") introduced a timeout per test. Livepatch tests could
> run longer than 45 seconds, especially on slower machines. They do not
> hang and they detect if something goes awry with internal accounting.
> 
> Better than looking for an arbitrary value, just disable the timeout for
> livepatch selftests.
> 
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>
> ---
>  tools/testing/selftests/livepatch/settings | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 tools/testing/selftests/livepatch/settings
> 
> diff --git a/tools/testing/selftests/livepatch/settings b/tools/testing/selftests/livepatch/settings
> new file mode 100644
> index 000000000000..e7b9417537fb
> --- /dev/null
> +++ b/tools/testing/selftests/livepatch/settings
> @@ -0,0 +1 @@
> +timeout=0
> -- 
> 2.23.0
> 

Yes, disabling the timeout for our tests makes sense since they already
have internal checking.  Tested this in a VM and looks good to me,
thanks.

Reviewed-by: Joe Lawrence <joe.lawrence@redhat.com>

-- Joe


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] selftests/livepatch: Disable the timeout
  2019-10-25 11:50 [PATCH] selftests/livepatch: Disable the timeout Miroslav Benes
  2019-10-25 14:14 ` Joe Lawrence
@ 2019-10-25 18:00 ` Jiri Kosina
  1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2019-10-25 18:00 UTC (permalink / raw)
  To: Miroslav Benes
  Cc: jpoimboe, pmladek, joe.lawrence, shuah, linux-kernel,
	live-patching, linux-kselftest

On Fri, 25 Oct 2019, Miroslav Benes wrote:

> Commit 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second
> timeout per test") introduced a timeout per test. Livepatch tests could
> run longer than 45 seconds, especially on slower machines. They do not
> hang and they detect if something goes awry with internal accounting.
> 
> Better than looking for an arbitrary value, just disable the timeout for
> livepatch selftests.
> 
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>
> ---
>  tools/testing/selftests/livepatch/settings | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 tools/testing/selftests/livepatch/settings
> 
> diff --git a/tools/testing/selftests/livepatch/settings b/tools/testing/selftests/livepatch/settings
> new file mode 100644
> index 000000000000..e7b9417537fb
> --- /dev/null
> +++ b/tools/testing/selftests/livepatch/settings
> @@ -0,0 +1 @@
> +timeout=0

Pushed to livepatching.git#for-5.5/selftests. Thanks,

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 11:50 [PATCH] selftests/livepatch: Disable the timeout Miroslav Benes
2019-10-25 14:14 ` Joe Lawrence
2019-10-25 18:00 ` Jiri Kosina

Live-Patching Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/live-patching/0 live-patching/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 live-patching live-patching/ https://lore.kernel.org/live-patching \
		live-patching@vger.kernel.org
	public-inbox-index live-patching

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.live-patching


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git