From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE48C4724C for ; Thu, 7 May 2020 10:00:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6410D2083B for ; Thu, 7 May 2020 10:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588845655; bh=bcDuPlK5Eisv/i5AZHvazLLY9XdRx5lz+/uXpfp9JV0=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=Anjta6Nv6jh1KX8L71w/rEXTjP+C25kycilv3ESSLIv77zElbmoRk/Fg0hggQ2Fo6 +b4RT0bntSlbviN95ADtNgg2/rIXqahHNgGd9G1bPov6u0Drwciq97LEKQXBjBQeIm xKJwTStXgsCFcPhrUvPYl4F7xnYB8zINCwHcexSM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726029AbgEGKAk (ORCPT ); Thu, 7 May 2020 06:00:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:38930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726222AbgEGKAS (ORCPT ); Thu, 7 May 2020 06:00:18 -0400 Received: from pobox.suse.cz (nat1.prg.suse.com [195.250.132.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A814C21473; Thu, 7 May 2020 10:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588845617; bh=bcDuPlK5Eisv/i5AZHvazLLY9XdRx5lz+/uXpfp9JV0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JjsIhurgsHOjFr9qWqQvkxxcy4ipTQLatYA569lhQObBh7lN947EJYsDjpAkEAPIa DEd0T3Jgb+mzWPee30GaH8plLJnVLwybi9eLGgyaqYjQlqzle0e8UabNznG975H/3X 3xHy2ae0ORM+laxQcVbParXO5zgCRycV6E8D8dpM= Date: Thu, 7 May 2020 12:00:13 +0200 (CEST) From: Jiri Kosina To: Josh Poimboeuf cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Jessica Yu , Joe Lawrence , Miroslav Benes , linux-s390@vger.kernel.org, Heiko Carstens , Gerald Schaefer , Christian Borntraeger Subject: Re: [PATCH v4 06/11] s390/module: Use s390_kernel_write() for late relocations In-Reply-To: <4710f82c960ff5f8b0dd7dba6aafde5bea275cfa.1588173720.git.jpoimboe@redhat.com> Message-ID: References: <4710f82c960ff5f8b0dd7dba6aafde5bea275cfa.1588173720.git.jpoimboe@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: live-patching-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: live-patching@vger.kernel.org On Wed, 29 Apr 2020, Josh Poimboeuf wrote: > From: Peter Zijlstra > > Because of late module patching, a livepatch module needs to be able to > apply some of its relocations well after it has been loaded. Instead of > playing games with module_{dis,en}able_ro(), use existing text poking > mechanisms to apply relocations after module loading. > > So far only x86, s390 and Power have HAVE_LIVEPATCH but only the first > two also have STRICT_MODULE_RWX. > > This will allow removal of the last module_disable_ro() usage in > livepatch. The ultimate goal is to completely disallow making > executable mappings writable. > > [ jpoimboe: Split up patches. Use mod state to determine whether > memcpy() can be used. Test and add fixes. ] > > Cc: linux-s390@vger.kernel.org > Cc: Heiko Carstens > Cc: Gerald Schaefer > Cc: Christian Borntraeger > Suggested-by: Josh Poimboeuf > Signed-off-by: Peter Zijlstra (Intel) > Signed-off-by: Josh Poimboeuf > Acked-by: Peter Zijlstra (Intel) > Acked-by: Joe Lawrence > Acked-by: Miroslav Benes Could we please get an Ack / Reviewed-by: for this patch from s390 folks? Thanks, -- Jiri Kosina SUSE Labs