From: Jingoo Han <jg1.han@samsung.com>
To: "'Geert Uytterhoeven'" <geert@linux-m68k.org>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"'Alessandro Zummo'" <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, "'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH 07/19] rtc: rtc-ps3: remove erroneous __init/__exit annotations
Date: Thu, 28 Feb 2013 18:36:59 +0900 [thread overview]
Message-ID: <000001ce1597$27e88d40$77b9a7c0$%han@samsung.com> (raw)
In-Reply-To: <CAMuHMdVgeXNUaGxzV=sicvVM8m_1sd0Xqm2njaRn9QqM=VibfQ@mail.gmail.com>
On Thursday, February 28, 2013 5:56 PM, Geert Uytterhoeven wrote:
>
> On Thu, Feb 28, 2013 at 9:41 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> > __init/__exit annotations for probe()/remove() are supposed to be
> > __devinit/__devexit, because __init/__exit for probe()/remove()
> > are not correct. However, __devinit/__devexit are not used,
> > because CONFIG_HOTPLUG was removed. Thus, these annotations
> > should be removed.
>
> Nack.
>
> This driver does not use platform_driver_register(), but
> platform_driver_probe().
> Hence the .probe can only be called from platform_driver_probe()
> (which is __init),
> not at any later time.
Oops, you are right.
In this case, bind/unbind via sysfs is disabled.
Also, other drivers I sent for use platform_driver_probe().
So, my patchset is useless.
Thank you for your comment :)
Best regards,
Jingoo Han
>
> I did not check the other drivers you sent patches for.
>
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > drivers/rtc/rtc-ps3.c | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/rtc/rtc-ps3.c b/drivers/rtc/rtc-ps3.c
> > index 968133c..8a24d11 100644
> > --- a/drivers/rtc/rtc-ps3.c
> > +++ b/drivers/rtc/rtc-ps3.c
> > @@ -58,7 +58,7 @@ static const struct rtc_class_ops ps3_rtc_ops = {
> > .set_time = ps3_set_time,
> > };
> >
> > -static int __init ps3_rtc_probe(struct platform_device *dev)
> > +static int ps3_rtc_probe(struct platform_device *dev)
> > {
> > struct rtc_device *rtc;
> >
> > @@ -71,7 +71,7 @@ static int __init ps3_rtc_probe(struct platform_device *dev)
> > return 0;
> > }
> >
> > -static int __exit ps3_rtc_remove(struct platform_device *dev)
> > +static int ps3_rtc_remove(struct platform_device *dev)
> > {
> > rtc_device_unregister(platform_get_drvdata(dev));
> > return 0;
> > @@ -82,7 +82,7 @@ static struct platform_driver ps3_rtc_driver = {
> > .name = "rtc-ps3",
> > .owner = THIS_MODULE,
> > },
> > - .remove = __exit_p(ps3_rtc_remove),
> > + .remove = ps3_rtc_remove,
> > };
> >
> > static int __init ps3_rtc_init(void)
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2013-02-28 9:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 8:38 [PATCH 01/19] rtc: rtc-mv: remove erroneous __exit annotation Jingoo Han
2013-02-28 8:39 ` [PATCH 02/19] rtc: rtc-davinci: remove erroneous __init annotation Jingoo Han
2013-02-28 8:39 ` [PATCH 03/19] rtc: rtc-ds1302: " Jingoo Han
2013-02-28 8:40 ` [PATCH 04/19] rtc: omap: remove erroneous __init/__exit annotations Jingoo Han
2013-02-28 8:40 ` [PATCH 05/19] rtc: rtc-efi: " Jingoo Han
2013-02-28 8:41 ` [PATCH 06/19] rtc: rtc-mc13xxx: " Jingoo Han
2013-02-28 8:41 ` [PATCH 07/19] rtc: rtc-ps3: " Jingoo Han
2013-02-28 8:56 ` Geert Uytterhoeven
2013-02-28 9:36 ` Jingoo Han [this message]
2013-02-28 8:41 ` [PATCH 08/19] rtc: rtc-coh901331: " Jingoo Han
2013-02-28 8:42 ` [PATCH 09/19] rtc: rtc-pxa: " Jingoo Han
2013-02-28 8:42 ` [PATCH 10/19] rtc: rtc-rp5c01: " Jingoo Han
2013-02-28 8:43 ` [PATCH 11/19] rtc: rtc-at32ap700x: " Jingoo Han
2013-02-28 8:43 ` [PATCH 12/19] rtc: rtc-ab3100: " Jingoo Han
2013-02-28 8:43 ` [PATCH 13/19] rtc: rtc-at91rm9200: " Jingoo Han
2013-02-28 8:44 ` [PATCH 14/19] rtc: msm6242: " Jingoo Han
2013-02-28 8:44 ` [PATCH 15/19] rtc: rtc-tx4939: " Jingoo Han
2013-02-28 8:45 ` [PATCH 16/19] rtc: rtc-sun4v: " Jingoo Han
2013-02-28 8:45 ` [PATCH 17/19] rtc: rtc-generic: " Jingoo Han
2013-02-28 8:46 ` [PATCH 18/19] rtc: rtc-sh: " Jingoo Han
2013-02-28 8:46 ` [PATCH 19/19] rtc: rtc-starfire: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001ce1597$27e88d40$77b9a7c0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).