From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754244AbcANPzq (ORCPT ); Thu, 14 Jan 2016 10:55:46 -0500 Received: from mailuogwhop.emc.com ([168.159.213.141]:38043 "EHLO mailuogwhop.emc.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750802AbcANPzp convert rfc822-to-8bit (ORCPT ); Thu, 14 Jan 2016 10:55:45 -0500 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd04.lss.emc.com u0EFtc7S030405 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd04.lss.emc.com u0EFtc7S030405 From: "Allen Hubbe" To: "'Xiangliang Yu'" , , , , Cc: References: <1452771830-16907-1-git-send-email-Xiangliang.Yu@amd.com> In-Reply-To: <1452771830-16907-1-git-send-email-Xiangliang.Yu@amd.com> Subject: RE: [PATCH V3 0/2] AMD NTB V3 changes Date: Thu, 14 Jan 2016 10:55:31 -0500 Message-ID: <000001d14ee3$ffd532c0$ff7f9840$@emc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQHRTpcvzH0aTyMQSkCriwGPUNjDl577Jdrg Content-Language: en-us X-RSA-Classifications: public X-Sentrion-Hostname: mailuogwprd04.lss.emc.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Xiangliang Yu > > Main changes in V3 > 1. Remove all power managment related code. Can you send the third patch with the power management code? I think it is important functionality. Furthermore, a review of the power management patch will help with getting the flush patch accepted. If the power management patch is reviewed and acked as is, the flush patch is probably ok, too, as is. If there are changes to power management that are also applicable to the flush patch, it would be good to keep it all consistent when adding the functionality to the api. > 2. Put makefile and kconfig changes in first patch. > 3. Call readl/writel directly, not use macros to hide it. I think this is almost ready. See comments in NTB: Add AMD PCI-Express NTB driver. Allen