linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Allen Hubbe" <Allen.Hubbe@emc.com>
To: "'Serge Semin'" <fancer.lancer@gmail.com>, <jdmason@kudzu.us>
Cc: <dave.jiang@intel.com>, <Xiangliang.Yu@amd.com>,
	<Sergey.Semin@t-platforms.ru>, <linux-ntb@googlegroups.com>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 0/3] ntb: Asynchronous NTB devices support
Date: Thu, 28 Jul 2016 10:42:30 -0400	[thread overview]
Message-ID: <000001d1e8de$463b4c10$d2b1e430$@emc.com> (raw)

From: Serge Semin
> Please, find the general patchset description in the cover letter of the first
> patchset (see the very first message in thread).
> 
> Changes in v2:
>  - Fix sparc64 compilation warning in drivers/ntb/hw/idt/ntb_hw_idt.c :
>    warning: right shift count >= width of type
>  - Fix sparc64 compilation warnings in drivers/ntb/test/ntb_mw_test.c :
>    warning: right shift count >= width of type
>    warning: cast to pointer from integer of different size

Thanks for reacting to the test robot so quickly.  Since nobody else has responded yet, I would like to assure you that the patches are not being ignored.  Please be patient.  The IDT driver will be a valuable contribution to the ntb subsystem.  I am working carefully through patch 1/3 first, since it affects existing drivers and interface.

A word of caution regarding your statement, "There are a some types of checkpatch warnings I left unfixed."  Coding style can be a touchy subject, leading to some recent rants^H^H^H^H^Hdiscussion on some of the same topics that are included in that list of unfixed warnings.  Be prepared to adhere to the style guide, even if it is inconvenient and against your own logic, because that is almost always the easier and more practical approach than asking for changes or exceptions, and better for your mental health not to be on the To: list of something like https://lkml.org/lkml/2016/7/8/625.

"Of course all of these warnings are discussable, except the last one."  Be prepared, even if it will require significant changes to the code.  For really inconvenient changes, we can talk about other more readily acceptable approaches to keep the code short and elegant, as is obviously your intent.  Please be patient with the review.

             reply	other threads:[~2016-07-28 14:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 14:42 Allen Hubbe [this message]
2016-07-29  0:47 ` [PATCH v2 0/3] ntb: Asynchronous NTB devices support Serge Semin
  -- strict thread matches above, loose matches on Subject: below --
2016-07-26 19:50 [PATCH " Serge Semin
2016-07-28 10:01 ` [PATCH v2 " Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001d1e8de$463b4c10$d2b1e430$@emc.com' \
    --to=allen.hubbe@emc.com \
    --cc=Sergey.Semin@t-platforms.ru \
    --cc=Xiangliang.Yu@amd.com \
    --cc=dave.jiang@intel.com \
    --cc=fancer.lancer@gmail.com \
    --cc=jdmason@kudzu.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntb@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).