From: "Sricharan" <sricharan@codeaurora.org>
To: "'Andy Gross'" <agross@codeaurora.org>
Cc: <devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
<iivanov@mm-sol.com>, <galak@codeaurora.org>,
<dmaengine@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH V2 2/6] i2c: qup: Add V2 tags support
Date: Wed, 8 Apr 2015 11:00:49 +0530 [thread overview]
Message-ID: <000201d071bd$30b1f130$9215d390$@codeaurora.org> (raw)
In-Reply-To: <20150407050640.GB9225@qualcomm.com>
Hi Andy,
> -----Original Message-----
> From: linux-arm-kernel [mailto:linux-arm-kernel-
> bounces@lists.infradead.org] On Behalf Of Andy Gross
> Sent: Tuesday, April 07, 2015 10:37 AM
> To: Sricharan R
> Cc: srichara@qti.qualcomm.com; devicetree@vger.kernel.org; linux-arm-
> msm@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> i2c@vger.kernel.org; iivanov@mm-sol.com; galak@codeaurora.org;
> dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V2 2/6] i2c: qup: Add V2 tags support
>
> On Tue, Apr 07, 2015 at 12:01:03AM +0530, Sricharan R wrote:
>
> <snip>
>
> > +static u32 qup_i2c_send_data(struct qup_i2c_dev *qup, int tlen, u8
*tbuf,
> > + int dlen, u8 *dbuf)
> > +{
> > + u32 val = 0, idx = 0, pos = 0, i = 0, t;
> > + int len = tlen + dlen;
> > + u8 *buf = tbuf;
> > +
> > + while (len > 0) {
> > + if (qup_i2c_wait_ready(qup, QUP_OUT_FULL, 0, 4)) {
>
> Instead of 0 and 4 can we use some #defines? This applies for all of the
> i2c_wait_ready calls
>
> <snip>
>
Ok, will change this with some macro.
Regards,
Sricharan
>
> --
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum, a Linux Foundation Collaborative Project
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2015-04-08 5:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 18:31 [PATCH V2 0/6] i2c: qup: Add support for v2 tags and bam dma Sricharan R
2015-04-06 18:31 ` [PATCH V2 1/6] i2c: qup: Change qup_wait_writeready function to use for all timeouts Sricharan R
2015-04-06 18:31 ` [PATCH V2 2/6] i2c: qup: Add V2 tags support Sricharan R
2015-04-07 5:06 ` Andy Gross
2015-04-08 5:30 ` Sricharan [this message]
2015-04-06 18:31 ` [PATCH V2 3/6] i2c: qup: Add bam dma capabilities Sricharan R
2015-04-06 18:31 ` [PATCH V2 4/6] i2c: qup: Transfer every i2c_msg in i2c_msgs without stop Sricharan R
2015-04-06 18:31 ` [PATCH V2 5/6] dts: msm8974: Add blsp2_bam dma node Sricharan R
2015-04-06 18:31 ` [PATCH V2 6/6] dts: msm8974: Add dma channels for blsp2_i2c1 node Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201d071bd$30b1f130$9215d390$@codeaurora.org' \
--to=sricharan@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).