From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Colin King'" <colin.king@canonical.com>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"'Sergey Senozhatsky'" <sergey.senozhatsky@gmail.com>,
"'Steve French'" <sfrench@samba.org>,
"'Hyunchul Lee'" <hyc.lee@gmail.com>,
<linux-cifs@vger.kernel.org>,
<linux-cifsd-devel@lists.sourceforge.net>
Subject: RE: [PATCH][next] cifsd: fix kfree of uninitialized pointer oid
Date: Fri, 11 Jun 2021 09:40:24 +0900 [thread overview]
Message-ID: <000201d75e5a$5da793d0$18f6bb70$@samsung.com> (raw)
In-Reply-To: <20210610164603.554691-1-colin.king@canonical.com>
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function ksmbd_neg_token_init_mech_type can kfree an uninitialized pointer oid when the call
> to asn1_oid_decode fails when vlen is out of range. All the other failure cases in function
> asn1_oid_decode set *oid to NULL on an error, so fix the issue by ensuring the vlen out of range error
> also nullifies the pointer.
>
> Fixes: 8bae4419ce63 ("cifsd: add goto fail in neg_token_init_mech_type()")
> Addresses-Coverity: ("Uninitialized pointer read")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
I will apply, Thanks for your patch!
prev parent reply other threads:[~2021-06-11 0:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210610164609epcas1p1c221f8a2c1762fc8a2e0cd5aa44c2b37@epcas1p1.samsung.com>
2021-06-10 16:46 ` [PATCH][next] cifsd: fix kfree of uninitialized pointer oid Colin King
2021-06-11 0:40 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201d75e5a$5da793d0$18f6bb70$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=colin.king@canonical.com \
--cc=hyc.lee@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-cifsd-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).