From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
"'Joao Pinto'" <Joao.Pinto@synopsys.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<nsekhar@ti.com>
Subject: Re: [PATCH v3] PCI: add a new directory for designware core
Date: Wed, 4 Jan 2017 15:15:54 -0500 [thread overview]
Message-ID: <000401d266c7$5a643f50$0f2cbdf0$@gmail.com> (raw)
In-Reply-To: <1483532367-9698-1-git-send-email-kishon@ti.com>
On Wednesday, January 4, 2017 7:19 AM, Kishon Vijay Abraham I wrote:
>
> Group all the PCI drivers that use designware core in dwc directory.
> dwc IP is capable of operating in both host mode and device mode and
> keeping it inside the *host* directory is misleading.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
However, I have two suggestion as below.
1. Please add dwc pci related people as possible.
They should be noticed. So, they will prepare this changes when they
will receive
future vanilla kernel.
2. Please use optimization option when you make patch.
The current patch is too huge.
This option will use 'rename' instead of 'create'/'delete'.
I am not sure, but maybe -M option will be used.
git format-patch -M
Best regards,
Jingoo Han
> ---
> Changes from v2:
> *) update MAINTAINERS file
>
> Changes from v1:
> *) instead of renaming *host* directory to *controller* directory,
> move all the dwc drivers to dwc/ directory.
> Next Steps:
> Split pcie-designware.c to core, host-only and endpoint-only files.
>
> MAINTAINERS | 22 +-
> drivers/pci/Kconfig | 1 +
> drivers/pci/Makefile | 3 +
> drivers/pci/dwc/Kconfig | 108 ++++
> drivers/pci/dwc/Makefile | 23 +
> drivers/pci/dwc/pci-dra7xx.c | 525 ++++++++++++++++++
> drivers/pci/dwc/pci-exynos.c | 629 +++++++++++++++++++++
> drivers/pci/dwc/pci-imx6.c | 757 ++++++++++++++++++++++++++
> drivers/pci/dwc/pci-keystone-dw.c | 560 +++++++++++++++++++
> drivers/pci/dwc/pci-keystone.c | 444 +++++++++++++++
> drivers/pci/dwc/pci-layerscape.c | 284 ++++++++++
> drivers/pci/dwc/pcie-armada8k.c | 254 +++++++++
> drivers/pci/dwc/pcie-artpec6.c | 283 ++++++++++
> drivers/pci/dwc/pcie-designware-plat.c | 126 +++++
> drivers/pci/dwc/pcie-designware.c | 902
> +++++++++++++++++++++++++++++++
> drivers/pci/dwc/pcie-designware.h | 86 +++
> drivers/pci/dwc/pcie-hisi.c | 326 +++++++++++
> drivers/pci/dwc/pcie-qcom.c | 753 ++++++++++++++++++++++++++
> drivers/pci/dwc/pcie-spear13xx.c | 299 ++++++++++
> drivers/pci/host/Kconfig | 113 ----
> drivers/pci/host/Makefile | 12 -
> drivers/pci/host/pci-dra7xx.c | 525 ------------------
> drivers/pci/host/pci-exynos.c | 629 ---------------------
> drivers/pci/host/pci-imx6.c | 757 --------------------------
> drivers/pci/host/pci-keystone-dw.c | 560 -------------------
> drivers/pci/host/pci-keystone.c | 444 ---------------
> drivers/pci/host/pci-layerscape.c | 284 ----------
> drivers/pci/host/pcie-armada8k.c | 254 ---------
> drivers/pci/host/pcie-artpec6.c | 283 ----------
> drivers/pci/host/pcie-designware-plat.c | 126 -----
> drivers/pci/host/pcie-designware.c | 902
---------------------------
> ----
> drivers/pci/host/pcie-designware.h | 86 ---
> drivers/pci/host/pcie-hisi.c | 326 -----------
> drivers/pci/host/pcie-qcom.c | 753 --------------------------
> drivers/pci/host/pcie-spear13xx.c | 299 ----------
> 35 files changed, 6374 insertions(+), 6364 deletions(-)
> create mode 100644 drivers/pci/dwc/Kconfig
> create mode 100644 drivers/pci/dwc/Makefile
> create mode 100644 drivers/pci/dwc/pci-dra7xx.c
> create mode 100644 drivers/pci/dwc/pci-exynos.c
> create mode 100644 drivers/pci/dwc/pci-imx6.c
> create mode 100644 drivers/pci/dwc/pci-keystone-dw.c
> create mode 100644 drivers/pci/dwc/pci-keystone.c
> create mode 100644 drivers/pci/dwc/pci-layerscape.c
> create mode 100644 drivers/pci/dwc/pcie-armada8k.c
> create mode 100644 drivers/pci/dwc/pcie-artpec6.c
> create mode 100644 drivers/pci/dwc/pcie-designware-plat.c
> create mode 100644 drivers/pci/dwc/pcie-designware.c
> create mode 100644 drivers/pci/dwc/pcie-designware.h
> create mode 100644 drivers/pci/dwc/pcie-hisi.c
> create mode 100644 drivers/pci/dwc/pcie-qcom.c
> create mode 100644 drivers/pci/dwc/pcie-spear13xx.c
> delete mode 100644 drivers/pci/host/pci-dra7xx.c
> delete mode 100644 drivers/pci/host/pci-exynos.c
> delete mode 100644 drivers/pci/host/pci-imx6.c
> delete mode 100644 drivers/pci/host/pci-keystone-dw.c
> delete mode 100644 drivers/pci/host/pci-keystone.c
> delete mode 100644 drivers/pci/host/pci-layerscape.c
> delete mode 100644 drivers/pci/host/pcie-armada8k.c
> delete mode 100644 drivers/pci/host/pcie-artpec6.c
> delete mode 100644 drivers/pci/host/pcie-designware-plat.c
> delete mode 100644 drivers/pci/host/pcie-designware.c
> delete mode 100644 drivers/pci/host/pcie-designware.h
> delete mode 100644 drivers/pci/host/pcie-hisi.c
> delete mode 100644 drivers/pci/host/pcie-qcom.c
> delete mode 100644 drivers/pci/host/pcie-spear13xx.c
next prev parent reply other threads:[~2017-01-04 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 12:19 [PATCH v3] PCI: add a new directory for designware core Kishon Vijay Abraham I
2017-01-04 15:10 ` Kishon Vijay Abraham I
2017-01-04 20:15 ` Jingoo Han [this message]
2017-01-05 5:06 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401d266c7$5a643f50$0f2cbdf0$@gmail.com' \
--to=jingoohan1@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).