From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D472AC11F69 for ; Thu, 1 Jul 2021 18:55:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B91456141F for ; Thu, 1 Jul 2021 18:55:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233700AbhGAS5j (ORCPT ); Thu, 1 Jul 2021 14:57:39 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:49036 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233505AbhGAS5i (ORCPT ); Thu, 1 Jul 2021 14:57:38 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1625165707; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=KHgqtWCUqBAcSdEPitK4LKTrMWMcbdMy+WpPKXHyE30=; b=Z9/XoDkMMheDj++XBz6NlE81bM+rfMdpIswPRpOks/vliWWGdaIDB/HUcfjiTux0uCXuScHa HDMZ/FpolZTleM04zgzZ1aw6SDk7gKYB/gAFT3xqOEEu3AwBqRuTe9yfOCFPAYE088Zp2NzV weSikVZg1TtzHjYtUTWJlqt6dhg= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 60de0f8aec0b18a745079611 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 01 Jul 2021 18:55:06 GMT Sender: okukatla=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8498FC43460; Thu, 1 Jul 2021 18:55:05 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: okukatla) by smtp.codeaurora.org (Postfix) with ESMTPSA id 58071C433D3; Thu, 1 Jul 2021 18:55:04 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 02 Jul 2021 00:25:04 +0530 From: okukatla@codeaurora.org To: Mike Tipton Cc: djakov@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, saravanak@google.com, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, mdtipton=codeaurora.org@codeaurora.org Subject: Re: [PATCH 2/4] interconnect: Always call pre_aggregate before aggregate In-Reply-To: <20210625212839.24155-3-mdtipton@codeaurora.org> References: <20210625212839.24155-1-mdtipton@codeaurora.org> <20210625212839.24155-3-mdtipton@codeaurora.org> Message-ID: <000574efe90897c1738299cfba4fea7d@codeaurora.org> X-Sender: okukatla@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-06-26 02:58, Mike Tipton wrote: > The pre_aggregate callback isn't called in all cases before calling > aggregate. Add the missing calls so providers can rely on consistent > framework behavior. > > Fixes: d3703b3e255f ("interconnect: Aggregate before setting initial > bandwidth") > Signed-off-by: Mike Tipton > --- > drivers/interconnect/core.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c > index 945121e18b5c..cfd54c90a6bb 100644 > --- a/drivers/interconnect/core.c > +++ b/drivers/interconnect/core.c > @@ -973,9 +973,12 @@ void icc_node_add(struct icc_node *node, struct > icc_provider *provider) > } > node->avg_bw = node->init_avg; > node->peak_bw = node->init_peak; > - if (provider->aggregate) > + if (provider->aggregate) { > + if (provider->pre_aggregate) > + provider->pre_aggregate(node); nit: we can invoke pre_aggregate() out side of if (qcom_icc_aggregate). > provider->aggregate(node, 0, node->init_avg, node->init_peak, > &node->avg_bw, &node->peak_bw); > + } > provider->set(node, node); > node->avg_bw = 0; > node->peak_bw = 0;