RE: [PATCH v3 2/2] therma: exynos: Supports thermal tripping

[Jonghwan Choi <jhbird.choi@samsung.com>]

Hi~


> >>                                 data->base + EXYNOS_THD_TEMP_RISE);
> >> @@ -665,6 +672,8 @@ static void exynos_tmu_control(struct
> platform_device
> >> *pdev, bool on)
> >>                 con &= ~(EXYNOS_TMU_TRIP_MODE_MASK | EXYNOS_MUX_ADDR_MASK);
> >>                 con |= pdata->noise_cancel_mode <<
> >> EXYNOS_TMU_TRIP_MODE_SHIFT;
> >>                 con |= (EXYNOS_MUX_ADDR_VALUE << EXYNOS_MUX_ADDR_SHIFT);
> >> +               if (pdata->trigger_levels[3])
> >> +                       con |= EXYNOS_TMU_TRIP_EN;
> >>         }
> Why don't you support trigger_level[3] in exynos4210 either? Even though
> 4210 doesn't support
> hardware tripping,
> I think it can be set in same way. I've done it in my local git with
> following codes.
> 

As follows, TRIP_EN is applied SOC_ARCH_EXYNOS(for exynos4412 & exynos5250).  (SOC_ARCH_EXYNOS4210 for exynos4210)

        if (data->soc == SOC_ARCH_EXYNOS) {
                con &= ~(EXYNOS_TMU_TRIP_MODE_MASK | EXYNOS_MUX_ADDR_MASK);
                con |= pdata->noise_cancel_mode << EXYNOS_TMU_TRIP_MODE_SHIFT;
                con |= (EXYNOS_MUX_ADDR_VALUE << EXYNOS_MUX_ADDR_SHIFT);
                if (pdata->trigger_levels[3])
                        con |= EXYNOS_TMU_TRIP_EN;
        }
And. Trigger_level3_en is not stored in INTEN(only level0~level2en)

Especially when temperature exceeds a extremely high threshold temperature
denoted as THRES_LEVEL_RISE3 field of THRESHOLD_TEMP_RISE register, then
Exynos5250 should not be damaged by the hot temperature. In this case, TMU
urgently sends active-high signal (THERM_TRIP) to PMU, and thermal tripping
by hardware logic i.e PMU (Power Management Unit) is performed. (From TMU document.) 

Trigger_leves[3] is only used for THERM_TRIP. Trigger_levels3_en doesn't  effect h/w tripping mode.
So i think trigger_levels[3] is better than trigger_level3_en.

Thanks~~^^



> -----Original Message-----
> From: jonghwa3.lee@samsung.com [mailto:jonghwa3.lee@samsung.com]
> Sent: Wednesday, November 21, 2012 1:02 PM
> To: Kyungmin Park
> Cc: Jonghwan Choi; jonghwa3.lee; open list; Amit Daniel Kachhap; Zhang Rui;
> Sachin Kamat
> Subject: Re: [PATCH v3 2/2] therma: exynos: Supports thermal tripping
> 
> Hi,
> On 2012년 11월 20일 10:40, Kyungmin Park wrote:
> > On 11/20/12, Jonghwan Choi <jhbird.choi@samsung.com> wrote:
> >> TMU urgently sends active-high signal (thermal trip) to PMU,
> >> and thermal tripping by hardware logic i.e PMU is performed.
> >> Thermal tripping means that PMU cut off the whole power of SoC
> >> by controlling external voltage regulator.
> >>
> >> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> > Ackedy-by: Kyungmin Park <kyungmin.park@samsung.com>
> >> ---
> >>  drivers/thermal/exynos_thermal.c |   10 ++++++++++
> >>  1 files changed, 10 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/thermal/exynos_thermal.c
> >> b/drivers/thermal/exynos_thermal.c
> >> index 129e827..569478d 100644
> >> --- a/drivers/thermal/exynos_thermal.c
> >> +++ b/drivers/thermal/exynos_thermal.c
> >> @@ -58,6 +58,7 @@
> >>  #define EXYNOS_TMU_CORE_ON             BIT(0)
> >>  #define EXYNOS_TMU_CORE_ON_SHIFT       0
> >>  #define EXYNOS_TMU_CORE_ON_MASK                (0x1 <<
> >> EXYNOS_TMU_CORE_ON_SHIFT)
> >> +#define EXYNOS_TMU_TRIP_EN             BIT(12)
> >>  #define EXYNOS_TMU_DEF_CODE_TO_TEMP_OFFSET     50
> >>
> >>  /* Exynos4210 specific registers */
> >> @@ -631,6 +632,12 @@ static int exynos_tmu_initialize(struct
> >> platform_device
> >> *pdev)
> >>                         goto out;
> >>                 }
> >>                 rising_threshold |= (threshold_code << 16);
> >> +               threshold_code = temp_to_code(data,
> >> pdata->trigger_levels[3]);
> >> +               if (threshold_code < 0) {
> >> +                       ret = threshold_code;
> >> +                       goto out;
> >> +               }
> >> +               rising_threshold |= (threshold_code << 24);
> >>
> >>                 writel(rising_threshold,
> >>                                 data->base + EXYNOS_THD_TEMP_RISE);
> >> @@ -665,6 +672,8 @@ static void exynos_tmu_control(struct
> platform_device
> >> *pdev, bool on)
> >>                 con &= ~(EXYNOS_TMU_TRIP_MODE_MASK | EXYNOS_MUX_ADDR_MASK);
> >>                 con |= pdata->noise_cancel_mode <<
> >> EXYNOS_TMU_TRIP_MODE_SHIFT;
> >>                 con |= (EXYNOS_MUX_ADDR_VALUE << EXYNOS_MUX_ADDR_SHIFT);
> >> +               if (pdata->trigger_levels[3])
> >> +                       con |= EXYNOS_TMU_TRIP_EN;
> >>         }
> Why don't you support trigger_level[3] in exynos4210 either? Even though
> 4210 doesn't support
> hardware tripping,
> I think it can be set in same way. I've done it in my local git with
> following codes.
> 
> if (data->soc == SOC_ARCH_EXYNOS4210)
> interrupt_en |= pdata->trigger_level3_en << 12;
> else
> con |= pdata->trigger_level3_en <<12;
> 
> How do you think of it?
> 
> Thanks.
> >>         if (on) {
> >> @@ -770,6 +779,7 @@ static struct exynos_tmu_platform_data const
> >> exynos_default_tmu_data = {
> >>         .trigger_levels[0] = 85,
> >>         .trigger_levels[1] = 103,
> >>         .trigger_levels[2] = 110,
> >> +       .trigger_levels[3] = 120,
> >>         .trigger_level0_en = 1,
> >>         .trigger_level1_en = 1,
> >>         .trigger_level2_en = 1,
> >> --
> >> 1.7.4.1
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >> Please read the FAQ at  http://www.tux.org/lkml/
> >>
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> >