From: <pillair@codeaurora.org>
To: "'Bjorn Andersson'" <bjorn.andersson@linaro.org>,
"'Stephen Boyd'" <swboyd@chromium.org>
Cc: <agross@kernel.org>, <mathieu.poirier@linaro.org>,
<ohad@wizery.com>, <p.zabel@pengutronix.de>, <robh+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sibis@codeaurora.org>,
<mpubbise@codeaurora.org>, <kuabhs@chromium.org>
Subject: RE: [PATCH v3 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support
Date: Wed, 22 Sep 2021 10:33:17 +0530 [thread overview]
Message-ID: <000b01d7af6f$2be09c50$83a1d4f0$@codeaurora.org> (raw)
In-Reply-To: <YUps1JfGtf6JdbCx@ripper>
> -----Original Message-----
> From: Bjorn Andersson <bjorn.andersson@linaro.org>
> Sent: Wednesday, September 22, 2021 5:08 AM
> To: Stephen Boyd <swboyd@chromium.org>
> Cc: Rakesh Pillai <pillair@codeaurora.org>; agross@kernel.org;
> mathieu.poirier@linaro.org; ohad@wizery.com; p.zabel@pengutronix.de;
> robh+dt@kernel.org; linux-arm-msm@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> sibis@codeaurora.org; mpubbise@codeaurora.org; kuabhs@chromium.org
> Subject: Re: [PATCH v3 2/3] dt-bindings: remoteproc: qcom: Add SC7280
> WPSS support
>
> On Thu 16 Sep 23:25 PDT 2021, Stephen Boyd wrote:
>
> > Quoting Rakesh Pillai (2021-09-16 09:55:52)
> > > @@ -78,6 +84,10 @@ properties:
> > > Phandle reference to a syscon representing TCSR followed by the
> > > three offsets within syscon for q6, modem and nc halt
registers.
> > >
> > > + qcom,qmp:
> > > + $ref: /schemas/types.yaml#/definitions/phandle
> > > + description: Reference to the AOSS side-channel message RAM.
> > > +
> > > qcom,smem-states:
> > > $ref: /schemas/types.yaml#/definitions/phandle-array
> > > description: States used by the AP to signal the Hexagon core
> > > @@ -117,6 +127,33 @@ allOf:
> > > compatible:
> > > contains:
> > > enum:
> > > + - qcom,sc7280-wpss-pil
> > > + then:
> >
> > Honestly I find this if/else to be a huge tangle. Why not split the
> > binding so that each compatible is a different file? Then it is easier
> > to read and see what properties to set.
> >
>
> Further more, the way we express the non-PAS properties in the PAS node
> in the dtsi and then switch the compatible in the non-PAS devices means
that
> we're causing validation errors.
>
> So we should explode this binding to get rid of the conditionals and to
> describe the "superset" of the PAS and non-PAS compatibles, for platforms
> where this is applicable.
>
> Regards,
> Bjorn
Hi Bjorn,
I have posted v4 for this patchseries with wpss dt-bindings added as a
separate file.
Can you please check v4 ?
Thanks,
Rakesh Pillai.
>
> > > + properties:
> > > + interrupts-extended:
> > > + maxItems: 6
> > > + items:
> > > + - description: Watchdog interrupt
> > > + - description: Fatal interrupt
> > > + - description: Ready interrupt
next prev parent reply other threads:[~2021-09-22 5:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 16:55 [PATCH v3 0/3] Add support for sc7280 WPSS PIL loading Rakesh Pillai
2021-09-16 16:55 ` [PATCH v3 1/3] dt-bindings: remoteproc: qcom: adsp: Convert binding to YAML Rakesh Pillai
2021-09-17 6:24 ` Stephen Boyd
2021-09-21 23:28 ` Rob Herring
2021-09-22 5:01 ` pillair
2021-09-16 16:55 ` [PATCH v3 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support Rakesh Pillai
2021-09-17 6:25 ` Stephen Boyd
2021-09-17 10:26 ` pillair
2021-09-21 23:37 ` Bjorn Andersson
2021-09-22 5:03 ` pillair [this message]
2021-09-16 16:55 ` [PATCH v3 3/3] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS Rakesh Pillai
2021-09-17 6:26 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01d7af6f$2be09c50$83a1d4f0$@codeaurora.org' \
--to=pillair@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kuabhs@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mpubbise@codeaurora.org \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).