From: Jingoo Han <jg1.han@samsung.com>
To: "'Krzysztof Kozlowski'" <k.kozlowski@samsung.com>
Cc: "'Alessandro Zummo'" <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
"'Andrew Morton'" <akpm@linux-foundation.org>,
"'Haojian Zhuang'" <haojian.zhuang@linaro.org>,
"'Sachin Kamat'" <sachin.kamat@linaro.org>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH RESEND 1/2] rtc: 88pm860x: Use of_get_child_by_name
Date: Wed, 23 Apr 2014 21:57:42 +0900 [thread overview]
Message-ID: <000c01cf5ef3$9d482a90$d7d87fb0$%han@samsung.com> (raw)
In-Reply-To: <1398256168-493-1-git-send-email-k.kozlowski@samsung.com>
On Wednesday, April 23, 2014 9:29 PM, Krzysztof Kozlowski wrote:
>
> Use of_get_child_by_name to obtain reference to charger node instead of
> of_find_node_by_name which can walk outside of the parent node.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/rtc/rtc-88pm860x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-88pm860x.c b/drivers/rtc/rtc-88pm860x.c
> index 816504846cdd..fb9e3c63b4ac 100644
> --- a/drivers/rtc/rtc-88pm860x.c
> +++ b/drivers/rtc/rtc-88pm860x.c
> @@ -293,7 +293,7 @@ static int pm860x_rtc_dt_init(struct platform_device *pdev,
> int ret;
> if (!np)
> return -ENODEV;
> - np = of_find_node_by_name(np, "rtc");
> + np = of_get_child_by_name(np, "rtc");
> if (!np) {
> dev_err(&pdev->dev, "failed to find rtc node\n");
> return -ENODEV;
> --
> 1.9.1
next prev parent reply other threads:[~2014-04-23 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 12:29 [PATCH RESEND 1/2] rtc: 88pm860x: Use of_get_child_by_name Krzysztof Kozlowski
2014-04-23 12:29 ` [PATCH RESEND 2/2] rtc: 88pm860x: Add missing of_node_put Krzysztof Kozlowski
2014-04-23 13:29 ` Jingoo Han
2014-04-23 12:57 ` Jingoo Han [this message]
2014-04-23 20:14 ` [PATCH RESEND 1/2] rtc: 88pm860x: Use of_get_child_by_name Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000c01cf5ef3$9d482a90$d7d87fb0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=haojian.zhuang@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).