From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755784AbbDUTNn (ORCPT ); Tue, 21 Apr 2015 15:13:43 -0400 Received: from mailout1.w2.samsung.com ([211.189.100.11]:51037 "EHLO usmailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754530AbbDUTNl (ORCPT ); Tue, 21 Apr 2015 15:13:41 -0400 X-Greylist: delayed 600 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Apr 2015 15:13:41 EDT X-AuditID: cbfec372-f798a6d000000e4f-28-55369f0b2491 Reply-to: kwan.huen@samsung.com From: Hingkwan Huen To: "'Jeff Moyer'" Cc: "'Matthew Wilcox'" , "'Keith Busch'" , "'Jens Axboe'" , "'Dimitri John Ledkov'" , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org References: <1429580863-3451-1-git-send-email-kwan.huen@samsung.com> <1429580863-3451-2-git-send-email-kwan.huen@samsung.com> In-reply-to: Subject: RE: [PATCH 1/2] added stream id write support Date: Tue, 21 Apr 2015 12:03:37 -0700 Organization: Samsung Semiconductor Message-id: <000f01d07c65$e0721b60$a1565220$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQK0oflgl9fJ8B072wt3Vi5IvruQ+QFbUbDbAo8VUJKbcDRUQA== Content-language: en-us X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsVy+t/hIF3u+WahBpveSFn833OMzWJX8xkm i7O/rrJY3Dv6hcli8/cONovLu+awWcxf9pTd4sDyoywOHB6zGnrZPCY2v2P3WLznJZPH5iX1 Hu/3XWXz+LxJLoAtissmJTUnsyy1SN8ugSvjfe8z1oLn3BX7J79hbGA8zNnFyMkhIWAiceja ekYIW0ziwr31bF2MXBxCAksYJY6eW88M4fxglNjwbw0TSJWQgLzEgptrWEFsNgFtieZzh9lA bBEBFYn3K9cyg9jMAj1MEpP+5kI0b2GUuHxyOVgDp4C9ROPdc2C2sICZxLEnvewgNouAqsS2 S39Zuhg5OPgFlCX+vCsGCfMKWEr0LvvDDGELSvyYfI8FYr6WxPqdx5kgbHmJzWveMkN8oCCx 4+xrRoh7nCQ2dh+DukdcYtKDh+wTGEVmIRk1C8moWUhGzULSsoCRZRWjaGlxckFxUnquoV5x Ym5xaV66XnJ+7iZGSMQV7WB8tsHqEKMAB6MSDy/DZNNQIdbEsuLK3EOMEhzMSiK8gkJmoUK8 KYmVValF+fFFpTmpxYcYpTlYlMR5HSQNQoUE0hNLUrNTUwtSi2CyTBycUg2MOgVRXcIODr42 0w92659I/TZr/Zcp5S8TjGUfNYZYvPryNdxp52PRT70nJ6RzW7fUSEYXRYYen3884I/CxgiX KPcVsk0ONRX72loUVryV5LAMf7NB4Xdb4TMX3hAGtv6rM5k/7bM+p+OnN3en2dGA9g3uqsse rtgt/7TwyeYGg61H84UYHUWVWIozEg21mIuKEwGIJwWatAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Jeff Moyer [mailto:jmoyer@redhat.com] > Sent: Tuesday, April 21, 2015 6:45 AM > To: kwan.huen > Cc: Matthew Wilcox; Keith Busch; Jens Axboe; Dimitri John Ledkov; linux- > nvme@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > api@vger.kernel.org > Subject: Re: [PATCH 1/2] added stream id write support > > "kwan.huen" writes: > > > --- > > drivers/block/nvme-core.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c > > index 85b8036..332341a 100644 > > --- a/drivers/block/nvme-core.c > > +++ b/drivers/block/nvme-core.c > > @@ -769,6 +769,9 @@ static int nvme_submit_iod(struct nvme_queue > *nvmeq, struct nvme_iod *iod, > > if (req->cmd_flags & REQ_RAHEAD) > > dsmgmt |= NVME_RW_DSM_FREQ_PREFETCH; > > > > + if (rq_data_dir(req)) > > + dsmgmt |= bio_get_streamid(req->bio) << 8; > > + > > There's no public specification for this, yet. How many bits are set aside for > the stream id? Do you need to do bounds checking/input validation? What > happens on adapters with older firmware when these bits are set? > > Cheers, > Jeff Thanks Jeff for the review! The patch depends on Jens' recent io-streamid patch set, and the new NVMe spec we are trying to get approved. The patch is probably still too early and we'll push this again when Jens' patches are released and the new spec goes public. Thanks, kwan