linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <pillair@codeaurora.org>
To: "'Stephen Boyd'" <swboyd@chromium.org>, <agross@kernel.org>,
	<bjorn.andersson@linaro.org>, <robh+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <sibis@codeaurora.org>,
	<mpubbise@codeaurora.org>, <kuabhs@chromium.org>
Subject: RE: [PATCH v3] arm64: dts: qcom: sc7280: Add WPSS remoteproc node
Date: Fri, 17 Sep 2021 13:34:39 +0530	[thread overview]
Message-ID: <001001d7ab9a$ad6e9de0$084bd9a0$@codeaurora.org> (raw)
In-Reply-To: <CAE-0n50Qmnxa8dz9pQbP408Y_vOu_8j1qeYFGo61W47WQkGunA@mail.gmail.com>



> -----Original Message-----
> From: Stephen Boyd <swboyd@chromium.org>
> Sent: Friday, September 17, 2021 6:25 AM
> To: Rakesh Pillai <pillair@codeaurora.org>; agross@kernel.org;
> bjorn.andersson@linaro.org; robh+dt@kernel.org
> Cc: linux-arm-msm@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; sibis@codeaurora.org; mpubbise@codeaurora.org;
> kuabhs@chromium.org
> Subject: Re: [PATCH v3] arm64: dts: qcom: sc7280: Add WPSS remoteproc
> node
> 
> Quoting Rakesh Pillai (2021-09-16 09:52:01)
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> > b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> > index 64fc22a..2b8bbcd 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> > @@ -1423,6 +1433,59 @@
> >                         #power-domain-cells = <1>;
> >                 };
> >
> > +               remoteproc_wpss: remoteproc@8a00000 {
> > +                       compatible = "qcom,sc7280-wpss-pil";
> > +                       reg = <0 0x08a00000 0 0x10000>;
> > +
> > +                       interrupts-extended = <&intc GIC_SPI 587
> IRQ_TYPE_EDGE_RISING>,
> > +                                             <&wpss_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> > +                                             <&wpss_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
> > +                                             <&wpss_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
> > +                                             <&wpss_smp2p_in 3 IRQ_TYPE_EDGE_RISING>,
> > +                                             <&wpss_smp2p_in 7 IRQ_TYPE_EDGE_RISING>;
> > +                       interrupt-names = "wdog", "fatal", "ready", "handover",
> > +                                         "stop-ack", "shutdown-ack";
> > +
> > +                       clocks = <&gcc GCC_WPSS_AHB_BDG_MST_CLK>,
> > +                                <&gcc GCC_WPSS_AHB_CLK>,
> > +                                <&gcc GCC_WPSS_RSCP_CLK>,
> > +                                <&rpmhcc RPMH_CXO_CLK>;
> > +                       clock-names = "gcc_wpss_ahb_bdg_mst_clk",
> > +                                     "gcc_wpss_ahb_clk",
> > +                                     "gcc_wpss_rscp_clk",
> > +                                     "xo";
> > +
> > +                       power-domains = <&rpmhpd SC7280_CX>,
> > +                                       <&rpmhpd SC7280_MX>;
> > +                       power-domain-names = "cx", "mx";
> > +
> > +                       memory-region = <&wpss_mem>;
> > +
> > +                       qcom,qmp = <&aoss_qmp>;
> > +
> > +                       qcom,smem-states = <&wpss_smp2p_out 0>;
> > +                       qcom,smem-state-names = "stop";
> > +
> > +                       resets = <&aoss_reset AOSS_CC_WCSS_RESTART>,
> > +                                <&pdc_reset PDC_WPSS_SYNC_RESET>;
> > +                       reset-names = "restart", "pdc_sync";
> > +
> > +                       qcom,halt-regs = <&tcsr_mutex_regs 0x37000>;
> 
> Where is this node defined? I don't see it on the mailing list for sc7280. Can
> you indicate what patches this depends on, and use git format-patch --base=
> so we can try to find them ourselves.

Hi Stephen,
My bad, it shud be "tcsr_mutex" instead of "tcsr_mutex_regs".
I will correct it and send v4.


      reply	other threads:[~2021-09-17  8:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 16:52 [PATCH v3] arm64: dts: qcom: sc7280: Add WPSS remoteproc node Rakesh Pillai
2021-09-17  0:55 ` Stephen Boyd
2021-09-17  8:04   ` pillair [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001001d7ab9a$ad6e9de0$084bd9a0$@codeaurora.org' \
    --to=pillair@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kuabhs@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpubbise@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=sibis@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).