From: Jim Lin <jilin@nvidia.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] usb: Add Clear_TT_Buffer support for XHCI
Date: Mon, 29 Apr 2019 17:40:47 +0800 [thread overview]
Message-ID: <00107302-c6e4-84a7-ebad-d3125c00c586@nvidia.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1904261128380.23806-100000@netrider.rowland.org>
Thanks for review.
Abandon this series of patches.
And will send out another minimized patch later.
Jim
On 2019年04月26日 23:34, Alan Stern wrote:
> On Fri, 26 Apr 2019, Jim Lin wrote:
>
>> Jim Lin (6):
>> usb: hub:Extend usb_hub_clear_tt_buffer parameter
>> usb: isp1760:Adjusted for usb_hub_clear_tt_buffer
>> usb: fotg210:Adjusted for usb_hub_clear_tt_buffer
>> usb: ehci: Adjusted for usb_hub_clear_tt_buffer
>> usb: dwc2: Adjusted for usb_hub_clear_tt_buffer
>> usb: xhci: Add Clear_TT_Buffer
>>
>> drivers/usb/core/hub.c | 5 +++--
>> drivers/usb/dwc2/hcd_intr.c | 2 +-
>> drivers/usb/host/ehci-q.c | 2 +-
>> drivers/usb/host/fotg210-hcd.c | 2 +-
>> drivers/usb/host/xhci-ring.c | 25 +++++++++++++++++++++++++
>> drivers/usb/host/xhci.c | 7 +++++++
>> drivers/usb/host/xhci.h | 3 +++
>> drivers/usb/isp1760/isp1760-hcd.c | 5 +++--
>> include/linux/usb/hcd.h | 2 +-
>> 9 files changed, 45 insertions(+), 8 deletions(-)
> This doesn't explain anything. After reading the patches, I could see
> that patches 2-5 are needed in order to work with patch 1, but I don't
> know why patch 1 was needed in the first place. It looks like patch 1
> forces callers to add an extra argument containing information that is
> already available, so why is the extra argument needed?
>
> In any case, this is the sort of the thing you should explain to people
> instead of forcing them to figure it out for themselves.
>
> Alan Stern
>
--nvpublic
prev parent reply other threads:[~2019-04-29 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 14:48 [PATCH 0/6] usb: Add Clear_TT_Buffer support for XHCI Jim Lin
2019-04-26 15:34 ` Alan Stern
2019-04-29 9:40 ` Jim Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00107302-c6e4-84a7-ebad-d3125c00c586@nvidia.com \
--to=jilin@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).