linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 10/16] f2fs: add core inode operations
@ 2012-10-05 12:02 김재극
  2012-10-05 20:28 ` Eric W. Biederman
  0 siblings, 1 reply; 4+ messages in thread
From: 김재극 @ 2012-10-05 12:02 UTC (permalink / raw)
  To: viro, 'Theodore Ts'o',
	gregkh, linux-kernel, chur.lee, cm224.lee, jaegeuk.kim,
	jooyoung.hwang

This adds core functions to get, read, write, and evict an inode.

Signed-off-by: Changman Lee <cm224.lee@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
---
 fs/f2fs/inode.c |  258 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 258 insertions(+)
 create mode 100644 fs/f2fs/inode.c

diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
new file mode 100644
index 0000000..1e409c2
--- /dev/null
+++ b/fs/f2fs/inode.c
@@ -0,0 +1,258 @@
+/**
+ * fs/f2fs/inode.c
+ *
+ * Copyright (c) 2012 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+#include <linux/fs.h>
+#include <linux/f2fs_fs.h>
+#include <linux/buffer_head.h>
+#include <linux/writeback.h>
+
+#include "f2fs.h"
+#include "node.h"
+
+struct f2fs_iget_args {
+	u64 ino;
+	int on_free;
+};
+
+void f2fs_set_inode_flags(struct inode *inode)
+{
+	unsigned int flags = F2FS_I(inode)->i_flags;
+
+	inode->i_flags &= ~(S_SYNC | S_APPEND | S_IMMUTABLE |
+			S_NOATIME | S_DIRSYNC);
+
+	if (flags & FS_SYNC_FL)
+		inode->i_flags |= S_SYNC;
+	if (flags & FS_APPEND_FL)
+		inode->i_flags |= S_APPEND;
+	if (flags & FS_IMMUTABLE_FL)
+		inode->i_flags |= S_IMMUTABLE;
+	if (flags & FS_NOATIME_FL)
+		inode->i_flags |= S_NOATIME;
+	if (flags & FS_DIRSYNC_FL)
+		inode->i_flags |= S_DIRSYNC;
+}
+
+static int f2fs_iget_test(struct inode *inode, void *data)
+{
+	struct f2fs_iget_args *args = data;
+
+	if (inode->i_ino != args->ino)
+		return 0;
+	if (inode->i_state & (I_FREEING | I_WILL_FREE)) {
+		args->on_free = 1;
+		return 0;
+	}
+	return 1;
+}
+
+struct inode *f2fs_iget_nowait(struct super_block *sb, unsigned long ino)
+{
+	struct f2fs_iget_args args = {
+		.ino = ino,
+		.on_free = 0
+	};
+	struct inode *inode = ilookup5(sb, ino, f2fs_iget_test, &args);
+
+	if (inode)
+		return inode;
+	if (!args.on_free)
+		return f2fs_iget(sb, ino);
+	return ERR_PTR(-ENOENT);
+}
+
+static int do_read_inode(struct inode *inode)
+{
+	struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb);
+	struct f2fs_inode_info *fi = F2FS_I(inode);
+	struct page *node_page;
+	struct f2fs_node *rn;
+	struct f2fs_inode *ri;
+
+	/* Check if ino is within scope */
+	check_nid_range(sbi, inode->i_ino);
+
+	node_page = get_node_page(sbi, inode->i_ino);
+	if (IS_ERR(node_page))
+		return PTR_ERR(node_page);
+
+	rn = page_address(node_page);
+	ri = &(rn->i);
+
+	inode->i_mode = le16_to_cpu(ri->i_mode);
+	inode->i_uid = le32_to_cpu(ri->i_uid);
+	inode->i_gid = le32_to_cpu(ri->i_gid);
+	set_nlink(inode, le32_to_cpu(ri->i_links));
+	inode->i_size = le64_to_cpu(ri->i_size);
+	inode->i_blocks = le64_to_cpu(ri->i_blocks);
+
+	inode->i_atime.tv_sec = le32_to_cpu(ri->i_atime);
+	inode->i_ctime.tv_sec = le32_to_cpu(ri->i_ctime);
+	inode->i_mtime.tv_sec = le32_to_cpu(ri->i_mtime);
+	inode->i_atime.tv_nsec = 0;
+	inode->i_ctime.tv_nsec = 0;
+	inode->i_mtime.tv_nsec = 0;
+	fi->current_depth = le32_to_cpu(ri->current_depth);
+	fi->i_xattr_nid = le32_to_cpu(ri->i_xattr_nid);
+	fi->i_flags = le32_to_cpu(ri->i_flags);
+	fi->flags = 0;
+	fi->data_version = le64_to_cpu(F2FS_CKPT(sbi)->checkpoint_ver) - 1;
+	get_extent_info(&fi->ext, ri->i_ext);
+	f2fs_put_page(node_page, 1);
+	return 0;
+}
+
+struct inode *f2fs_iget(struct super_block *sb, unsigned long ino)
+{
+	struct f2fs_sb_info *sbi = F2FS_SB(sb);
+	struct inode *inode;
+	int ret;
+
+	inode = iget_locked(sb, ino);
+	if (!inode)
+		return ERR_PTR(-ENOMEM);
+	if (!(inode->i_state & I_NEW))
+		return inode;
+	if (ino == F2FS_NODE_INO(sbi) || ino == F2FS_META_INO(sbi))
+		goto make_now;
+
+	ret = do_read_inode(inode);
+	if (ret)
+		goto bad_inode;
+
+	if (!sbi->por_doing && inode->i_nlink == 0) {
+		ret = -ENOENT;
+		goto bad_inode;
+	}
+
+make_now:
+	if (ino == F2FS_NODE_INO(sbi)) {
+		inode->i_mapping->a_ops = &f2fs_node_aops;
+		mapping_set_gfp_mask(inode->i_mapping, GFP_F2FS_MOVABLE);
+	} else if (ino == F2FS_META_INO(sbi)) {
+		inode->i_mapping->a_ops = &f2fs_meta_aops;
+		mapping_set_gfp_mask(inode->i_mapping, GFP_F2FS_MOVABLE);
+	} else if (S_ISREG(inode->i_mode)) {
+		inode->i_op = &f2fs_file_inode_operations;
+		inode->i_fop = &f2fs_file_operations;
+		inode->i_mapping->a_ops = &f2fs_dblock_aops;
+	} else if (S_ISDIR(inode->i_mode)) {
+		inode->i_op = &f2fs_dir_inode_operations;
+		inode->i_fop = &f2fs_dir_operations;
+		inode->i_mapping->a_ops = &f2fs_dblock_aops;
+		mapping_set_gfp_mask(inode->i_mapping, GFP_HIGHUSER_MOVABLE |
+				__GFP_ZERO);
+	} else if (S_ISLNK(inode->i_mode)) {
+		inode->i_op = &f2fs_symlink_inode_operations;
+		inode->i_mapping->a_ops = &f2fs_dblock_aops;
+	} else if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode) ||
+			S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) {
+		inode->i_op = &f2fs_special_inode_operations;
+		init_special_inode(inode, inode->i_mode, inode->i_rdev);
+	} else {
+		ret = -EIO;
+		goto bad_inode;
+	}
+	unlock_new_inode(inode);
+
+	return inode;
+
+bad_inode:
+	iget_failed(inode);
+	return ERR_PTR(ret);
+}
+
+void update_inode(struct inode *inode, struct page *node_page)
+{
+	struct f2fs_node *rn;
+	struct f2fs_inode *ri;
+
+	wait_on_page_writeback(node_page);
+
+	rn = page_address(node_page);
+	ri = &(rn->i);
+
+	ri->i_mode = cpu_to_le16(inode->i_mode);
+	ri->i_uid = cpu_to_le32(inode->i_uid);
+	ri->i_gid = cpu_to_le32(inode->i_gid);
+	ri->i_links = cpu_to_le32(inode->i_nlink);
+	ri->i_size = cpu_to_le64(i_size_read(inode));
+	ri->i_blocks = cpu_to_le64(inode->i_blocks);
+	set_raw_extent(&F2FS_I(inode)->ext, &ri->i_ext);
+
+	ri->i_ctime = cpu_to_le32(inode->i_ctime.tv_sec);
+	ri->i_mtime = cpu_to_le32(inode->i_mtime.tv_sec);
+	ri->i_atime = cpu_to_le32(inode->i_atime.tv_sec);
+	ri->current_depth = cpu_to_le32(F2FS_I(inode)->current_depth);
+	ri->i_xattr_nid = cpu_to_le32(F2FS_I(inode)->i_xattr_nid);
+	ri->i_flags = cpu_to_le32(F2FS_I(inode)->i_flags);
+	set_page_dirty(node_page);
+}
+
+int f2fs_write_inode(struct inode *inode, struct writeback_control *wbc)
+{
+	struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb);
+	struct page *node_page;
+	bool need_lock = false;
+
+	if (inode->i_ino == F2FS_NODE_INO(sbi) ||
+			inode->i_ino == F2FS_META_INO(sbi))
+		return 0;
+
+	node_page = get_node_page(sbi, inode->i_ino);
+	if (IS_ERR(node_page))
+		return PTR_ERR(node_page);
+
+	if (!PageDirty(node_page)) {
+		need_lock = true;
+		f2fs_put_page(node_page, 1);
+		mutex_lock(&sbi->write_inode);
+		node_page = get_node_page(sbi, inode->i_ino);
+		if (IS_ERR(node_page)) {
+			mutex_unlock(&sbi->write_inode);
+			return PTR_ERR(node_page);
+		}
+	}
+	update_inode(inode, node_page);
+	f2fs_put_page(node_page, 1);
+	if (need_lock)
+		mutex_unlock(&sbi->write_inode);
+	return 0;
+}
+
+/**
+ * Called at the last iput() if i_nlink is zero
+ */
+void f2fs_evict_inode(struct inode *inode)
+{
+	struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb);
+
+	truncate_inode_pages(&inode->i_data, 0);
+
+	if (inode->i_ino == F2FS_NODE_INO(sbi) ||
+			inode->i_ino == F2FS_META_INO(sbi))
+		goto no_delete;
+
+	BUG_ON(atomic_read(&F2FS_I(inode)->dirty_dents));
+	remove_dirty_dir_inode(inode);
+
+	if (inode->i_nlink || is_bad_inode(inode))
+		goto no_delete;
+
+	set_inode_flag(F2FS_I(inode), FI_NO_ALLOC);
+	i_size_write(inode, 0);
+
+	if (F2FS_HAS_BLOCKS(inode))
+		f2fs_truncate(inode);
+
+	remove_inode_page(inode);
+no_delete:
+	clear_inode(inode);
+}
-- 
1.7.9.5




---
Jaegeuk Kim
Samsung




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 10/16] f2fs: add core inode operations
  2012-10-05 12:02 [PATCH 10/16] f2fs: add core inode operations 김재극
@ 2012-10-05 20:28 ` Eric W. Biederman
  2012-10-06 18:06   ` Jaegeuk Kim
       [not found]   ` <CAN863Pu_W4P74oQyJQnkXhUW+q-0zJR7F+gW_n6JqoOQOwG0ww@mail.gmail.com>
  0 siblings, 2 replies; 4+ messages in thread
From: Eric W. Biederman @ 2012-10-05 20:28 UTC (permalink / raw)
  To: 김재극
  Cc: viro, 'Theodore Ts'o',
	gregkh, linux-kernel, chur.lee, cm224.lee, jooyoung.hwang

김재극 <jaegeuk.kim@samsung.com> writes:

> This adds core functions to get, read, write, and evict an inode.

As is this code won't compile if user namespace support is enabled.
Suggested fixes below.

Eric


> +static int do_read_inode(struct inode *inode)
> +{
> +	struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb);
> +	struct f2fs_inode_info *fi = F2FS_I(inode);
> +	struct page *node_page;
> +	struct f2fs_node *rn;
> +	struct f2fs_inode *ri;
> +
> +	/* Check if ino is within scope */
> +	check_nid_range(sbi, inode->i_ino);
> +
> +	node_page = get_node_page(sbi, inode->i_ino);
> +	if (IS_ERR(node_page))
> +		return PTR_ERR(node_page);
> +
> +	rn = page_address(node_page);
> +	ri = &(rn->i);
> +
> +	inode->i_mode = le16_to_cpu(ri->i_mode);
> +	inode->i_uid = le32_to_cpu(ri->i_uid);
> +	inode->i_gid = le32_to_cpu(ri->i_gid);

Could you make this:
	i_uid_write(inode, le32_to_cpu(ri->i_uid));
	i_gid_write(inode, le32_to_cpu(ri->i_gid));

> +	set_nlink(inode, le32_to_cpu(ri->i_links));
> +	inode->i_size = le64_to_cpu(ri->i_size);
> +	inode->i_blocks = le64_to_cpu(ri->i_blocks);
> +
> +	inode->i_atime.tv_sec = le32_to_cpu(ri->i_atime);
> +	inode->i_ctime.tv_sec = le32_to_cpu(ri->i_ctime);
> +	inode->i_mtime.tv_sec = le32_to_cpu(ri->i_mtime);
> +	inode->i_atime.tv_nsec = 0;
> +	inode->i_ctime.tv_nsec = 0;
> +	inode->i_mtime.tv_nsec = 0;
> +	fi->current_depth = le32_to_cpu(ri->current_depth);
> +	fi->i_xattr_nid = le32_to_cpu(ri->i_xattr_nid);
> +	fi->i_flags = le32_to_cpu(ri->i_flags);
> +	fi->flags = 0;
> +	fi->data_version = le64_to_cpu(F2FS_CKPT(sbi)->checkpoint_ver) - 1;
> +	get_extent_info(&fi->ext, ri->i_ext);
> +	f2fs_put_page(node_page, 1);
> +	return 0;
> +}

> +void update_inode(struct inode *inode, struct page *node_page)
> +{
> +	struct f2fs_node *rn;
> +	struct f2fs_inode *ri;
> +
> +	wait_on_page_writeback(node_page);
> +
> +	rn = page_address(node_page);
> +	ri = &(rn->i);
> +
> +	ri->i_mode = cpu_to_le16(inode->i_mode);
> +	ri->i_uid = cpu_to_le32(inode->i_uid);
> +	ri->i_gid = cpu_to_le32(inode->i_gid);
And make this:
	i_uid_write(inode, le32_to_cpu(ri->i_uid));
	i_gid_write(inode, le32_to_cpu(ri->i_gid));

> +	ri->i_links = cpu_to_le32(inode->i_nlink);
> +	ri->i_size = cpu_to_le64(i_size_read(inode));
> +	ri->i_blocks = cpu_to_le64(inode->i_blocks);
> +	set_raw_extent(&F2FS_I(inode)->ext, &ri->i_ext);
> +
> +	ri->i_ctime = cpu_to_le32(inode->i_ctime.tv_sec);
> +	ri->i_mtime = cpu_to_le32(inode->i_mtime.tv_sec);
> +	ri->i_atime = cpu_to_le32(inode->i_atime.tv_sec);
> +	ri->current_depth = cpu_to_le32(F2FS_I(inode)->current_depth);
> +	ri->i_xattr_nid = cpu_to_le32(F2FS_I(inode)->i_xattr_nid);
> +	ri->i_flags = cpu_to_le32(F2FS_I(inode)->i_flags);
> +	set_page_dirty(node_page);
> +}

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 10/16] f2fs: add core inode operations
  2012-10-05 20:28 ` Eric W. Biederman
@ 2012-10-06 18:06   ` Jaegeuk Kim
       [not found]   ` <CAN863Pu_W4P74oQyJQnkXhUW+q-0zJR7F+gW_n6JqoOQOwG0ww@mail.gmail.com>
  1 sibling, 0 replies; 4+ messages in thread
From: Jaegeuk Kim @ 2012-10-06 18:06 UTC (permalink / raw)
  To: Eric W. Biederman
  Cc: 김재극, viro, 'Theodore Ts'o',
	gregkh, linux-kernel, chur.lee, cm224.lee, jooyoung.hwang

2012-10-05 (금), 13:28 -0700, Eric W. Biederman:
> 김재극 <jaegeuk.kim@samsung.com> writes:
> 
> > This adds core functions to get, read, write, and evict an inode.
> 
> As is this code won't compile if user namespace support is enabled.
> Suggested fixes below.

Ok, I'll check this out.
Thanks,

> 
> Eric
> 
> 
> > +static int do_read_inode(struct inode *inode)
> > +{
> > +	struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb);
> > +	struct f2fs_inode_info *fi = F2FS_I(inode);
> > +	struct page *node_page;
> > +	struct f2fs_node *rn;
> > +	struct f2fs_inode *ri;
> > +
> > +	/* Check if ino is within scope */
> > +	check_nid_range(sbi, inode->i_ino);
> > +
> > +	node_page = get_node_page(sbi, inode->i_ino);
> > +	if (IS_ERR(node_page))
> > +		return PTR_ERR(node_page);
> > +
> > +	rn = page_address(node_page);
> > +	ri = &(rn->i);
> > +
> > +	inode->i_mode = le16_to_cpu(ri->i_mode);
> > +	inode->i_uid = le32_to_cpu(ri->i_uid);
> > +	inode->i_gid = le32_to_cpu(ri->i_gid);
> 
> Could you make this:
> 	i_uid_write(inode, le32_to_cpu(ri->i_uid));
> 	i_gid_write(inode, le32_to_cpu(ri->i_gid));
> 
> > +	set_nlink(inode, le32_to_cpu(ri->i_links));
> > +	inode->i_size = le64_to_cpu(ri->i_size);
> > +	inode->i_blocks = le64_to_cpu(ri->i_blocks);
> > +
> > +	inode->i_atime.tv_sec = le32_to_cpu(ri->i_atime);
> > +	inode->i_ctime.tv_sec = le32_to_cpu(ri->i_ctime);
> > +	inode->i_mtime.tv_sec = le32_to_cpu(ri->i_mtime);
> > +	inode->i_atime.tv_nsec = 0;
> > +	inode->i_ctime.tv_nsec = 0;
> > +	inode->i_mtime.tv_nsec = 0;
> > +	fi->current_depth = le32_to_cpu(ri->current_depth);
> > +	fi->i_xattr_nid = le32_to_cpu(ri->i_xattr_nid);
> > +	fi->i_flags = le32_to_cpu(ri->i_flags);
> > +	fi->flags = 0;
> > +	fi->data_version = le64_to_cpu(F2FS_CKPT(sbi)->checkpoint_ver) - 1;
> > +	get_extent_info(&fi->ext, ri->i_ext);
> > +	f2fs_put_page(node_page, 1);
> > +	return 0;
> > +}
> 
> > +void update_inode(struct inode *inode, struct page *node_page)
> > +{
> > +	struct f2fs_node *rn;
> > +	struct f2fs_inode *ri;
> > +
> > +	wait_on_page_writeback(node_page);
> > +
> > +	rn = page_address(node_page);
> > +	ri = &(rn->i);
> > +
> > +	ri->i_mode = cpu_to_le16(inode->i_mode);
> > +	ri->i_uid = cpu_to_le32(inode->i_uid);
> > +	ri->i_gid = cpu_to_le32(inode->i_gid);
> And make this:
> 	i_uid_write(inode, le32_to_cpu(ri->i_uid));
> 	i_gid_write(inode, le32_to_cpu(ri->i_gid));
> 
> > +	ri->i_links = cpu_to_le32(inode->i_nlink);
> > +	ri->i_size = cpu_to_le64(i_size_read(inode));
> > +	ri->i_blocks = cpu_to_le64(inode->i_blocks);
> > +	set_raw_extent(&F2FS_I(inode)->ext, &ri->i_ext);
> > +
> > +	ri->i_ctime = cpu_to_le32(inode->i_ctime.tv_sec);
> > +	ri->i_mtime = cpu_to_le32(inode->i_mtime.tv_sec);
> > +	ri->i_atime = cpu_to_le32(inode->i_atime.tv_sec);
> > +	ri->current_depth = cpu_to_le32(F2FS_I(inode)->current_depth);
> > +	ri->i_xattr_nid = cpu_to_le32(F2FS_I(inode)->i_xattr_nid);
> > +	ri->i_flags = cpu_to_le32(F2FS_I(inode)->i_flags);
> > +	set_page_dirty(node_page);
> > +}
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Jaegeuk Kim
Samsung




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 10/16] f2fs: add core inode operations
       [not found]   ` <CAN863Pu_W4P74oQyJQnkXhUW+q-0zJR7F+gW_n6JqoOQOwG0ww@mail.gmail.com>
@ 2012-10-08 16:35     ` Eric W. Biederman
  0 siblings, 0 replies; 4+ messages in thread
From: Eric W. Biederman @ 2012-10-08 16:35 UTC (permalink / raw)
  To: Changman Lee
  Cc: 김재극,
	Theodore Ts'o, gregkh, linux-kernel, jooyoung.hwang, viro,
	chur.lee, cm224.lee

Changman Lee <cm224.lee@gmail.com> writes:
>> > +void update_inode(struct inode *inode, struct page *node_page)
>> > +{
>> > +     struct f2fs_node *rn;
>> > +     struct f2fs_inode *ri;
>> > +
>> > +     wait_on_page_writeback(node_page);
>> > +
>> > +     rn = page_address(node_page);
>> > +     ri = &(rn->i);
>> > +
>> > +     ri->i_mode = cpu_to_le16(inode->i_mode);
>> > +     ri->i_uid = cpu_to_le32(inode->i_uid);
>> > +     ri->i_gid = cpu_to_le32(inode->i_gid);
>> And make this:
>>         i_uid_write(inode, le32_to_cpu(ri->i_uid));
>>         i_gid_write(inode, le32_to_cpu(ri->i_gid));
>>
>
> You mean this. Right? :)
> ri->i_uid = cpu_to_le32(i_uid_read(inode));
> ri->i_gid = cpu_to_le32(i_gid_read(inode));

Yeah. ;)

I did have that one backwards.

Eric

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-10-08 16:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-05 12:02 [PATCH 10/16] f2fs: add core inode operations 김재극
2012-10-05 20:28 ` Eric W. Biederman
2012-10-06 18:06   ` Jaegeuk Kim
     [not found]   ` <CAN863Pu_W4P74oQyJQnkXhUW+q-0zJR7F+gW_n6JqoOQOwG0ww@mail.gmail.com>
2012-10-08 16:35     ` Eric W. Biederman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).